Remove custom implementation of percent_encode #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can rely on the standard library starting from Python 3.7.
technige
reviewed
Jan 15, 2024
| # within the 'ALWAYS_SAFE' list. The character was added in Python 3.7 | ||
| safe = "".join(_QUOTE_ALWAYS_SAFE.union(set(safe))) | ||
| # This function used to add `~` to unreserverd characters, but this was fixed in Python 3.7. | ||
| # Keeping the function here as it is part of the public API. |
There was a problem hiding this comment.
Can the function be deprecated, though? My guess is that we'd want to steer people away from using a custom function now that it is simply a wrapper.
There was a problem hiding this comment.
It can be deprecated, but is currently used in elasticsearch-py. I'll look into doing it, thanks.
There was a problem hiding this comment.
Currently blocked by elastic/elasticsearch-py#2268.
There was a problem hiding this comment.
pquentin
force-pushed
the
percent-encode
branch
from
18697bd
to
e6be2fb
Compare
xrmx
approved these changes
Feb 23, 2024
|
Sorry, this is not done yet. I need to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can rely on the standard library starting from Python 3.7. See https://docs.python.org/3/library/urllib.parse.html#urllib.parse.quote.