Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 16.3 and migrate away from deprecated lifecycle methods #763

Closed
cjcenizal opened this issue May 3, 2018 · 5 comments
Closed
Labels

Comments

@cjcenizal
Copy link
Contributor

See elastic/kibana#17432 for more info. I think this issue should be blocked until that issue is resolved so that we don't introduce incompatibilities with Kibana.

CC @chandlerprall

@cjcenizal cjcenizal changed the title Upgrade to React 16.3 and remove deprecated lifecycle methods Upgrade to React 16.3 and migrate away from deprecated lifecycle methods May 3, 2018
@chandlerprall
Copy link
Contributor

We should be able to address the deprecated lifecycle methods without impacting downstream users.

@chandlerprall
Copy link
Contributor

chandlerprall commented May 3, 2018

Talked with CJ more; we'll split this up into 3 phases:

  • identify instances in EUI that use the deprecated lifecycle methods, mark them with // TODO React 16.3 and when possible add some thoughts on how the instance should be updated
  • update components to the new lifecycle methods
  • after downstream projects (e.g. Kibana) have updated to 16.3 address the remaining instances and update EUI's react peerDependency to ^16.3 (Kibana already updated)

@chandlerprall
Copy link
Contributor

Kibana has been updated to 16.3, no blockers for this.

@chandlerprall
Copy link
Contributor

All EUI components are updated off of the deprecated lifecycle methods.

@snide
Copy link
Contributor

snide commented Jun 1, 2018

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants