added TODOs to the lifecycle methods deprecated in react 16.3 #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
approved these changes
May 17, 2018
| @@ -248,6 +248,7 @@ export class EuiBasicTable extends Component { | |||
| this.props.onChange(criteria); | |||
| } | |||
|
|
|||
| // @TODO: React 16.3 - getDerivedStateFromProps | |||
There was a problem hiding this comment.
Could you also update the other TODO comments inside src to follow the form @TODO? This way we won't miss them if we grep for @TODO. Either that or change these @TODO to TODO for consistency, either way is fine to me.
There was a problem hiding this comment.
Changed to match existing TODO format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the first step in #763 by adding TODOs to the locations where EUI uses the React lifecycle methods that were deprecated in 16.3. Each comment includes a suggestion for how to move that instance off the deprecated method.