Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint rule for requiring ts-ignore descriptions #3584

Merged
merged 12 commits into from
Jun 11, 2020
Merged

Lint rule for requiring ts-ignore descriptions #3584

merged 12 commits into from
Jun 11, 2020

Commits on Jun 9, 2020

  1. upgrades @typescript-eslint plugin and parser (removes deprecated rules) 

    as well as runs prettier on .eslintrc.js
    @dimitropoulos
    dimitropoulos committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    6c5020d View commit details
    Browse the repository at this point in the history

  2. turns off new (unwanted) rules

    @dimitropoulos
    dimitropoulos committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    18e54cf View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. only allows ts-ignore and ts-expect-error with descriptions

    @dimitropoulos
    dimitropoulos committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    0cdcf3f View commit details
    Browse the repository at this point in the history

  2. tweaks for new @typescript-eslint version

    @dimitropoulos
    dimitropoulos committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    7319764 View commit details
    Browse the repository at this point in the history

  3. clears error for 'prefer-as-const' lint rule 

    this used to be required to get a behavior that has since been filpped to always work the 'as const' way, so this is no longer necessary (hence the lint rule complaining)
    @dimitropoulos
    dimitropoulos committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    9a3f39f View commit details
    Browse the repository at this point in the history

  4. removes disable for rule that no longer exists 

    interface-name-prefix was replaced by naming-convention in @typescript-eslint v3
    @dimitropoulos
    dimitropoulos committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    f330930 View commit details
    Browse the repository at this point in the history

  5. removes ts-ignore-next-line usages (that's not a thing)

    @dimitropoulos
    dimitropoulos committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    305eb69 View commit details
    Browse the repository at this point in the history

  6. use for sort Direction

    @dimitropoulos
    dimitropoulos committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    009ae6e View commit details
    Browse the repository at this point in the history

  7. uses for all ts-ignores that need it

    @dimitropoulos
    dimitropoulos committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    d0f9f2b View commit details
    Browse the repository at this point in the history

  8. solves simplest ts-ignore cases 

    some simply just needed to be removed (mostly due to ignores for files that didn't used to have types but now do)
    @dimitropoulos
    dimitropoulos committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    98ea46b View commit details
    Browse the repository at this point in the history

  9. Clean up ts-ignore todos

    @chandlerprall
    chandlerprall committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    5206890 View commit details
    Browse the repository at this point in the history

  10. Merge pull request #1 from chandlerprall/ts-comment-allow-with-descri… 

    …ption

Clean up ts-ignore todos
    @dimitropoulos
    dimitropoulos committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    2464d49 View commit details
    Browse the repository at this point in the history