Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] feat: Add support to kibana 6.8 chart for deployment annotations #1754

Open
wants to merge 1 commit into
base: 6.8
Choose a base branch
from

Conversation

JDKnobloch
Copy link

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

^ Unsure if integration test updates are needed with this feature.

This PR creates the ability to add deployment annotations for those using 6.8 versions of elastic. Code used from when changes were introduced to newer versions of the chart in #1417.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link

@dsn dsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JDKnobloch
Copy link
Author

@jmlrt @Kushmaro how do we get someone to review these changes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants