use internalError for exceptions in authenticator

elastic · Aug 2, 2019 · 6fb0fec · 6fb0fec
1 parent 534ad91
commit 6fb0fec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/x-pack/plugins/security/server/authentication/index.test.ts b/x-pack/plugins/security/server/authentication/index.test.ts
@@ -141,7 +141,7 @@ describe('setupAuthentication()', () => {
       expect(mockAuthToolkit.authenticated).toHaveBeenCalledTimes(1);
       expect(mockAuthToolkit.authenticated).toHaveBeenCalledWith();
       expect(mockResponse.redirected).not.toHaveBeenCalled();
-      expect(mockResponse.unauthorized).not.toHaveBeenCalled();
+      expect(mockResponse.internalError).not.toHaveBeenCalled();
 
       expect(authenticate).not.toHaveBeenCalled();
     });
@@ -164,7 +164,7 @@ describe('setupAuthentication()', () => {
         requestHeaders: mockAuthHeaders,
       });
       expect(mockResponse.redirected).not.toHaveBeenCalled();
-      expect(mockResponse.unauthorized).not.toHaveBeenCalled();
+      expect(mockResponse.internalError).not.toHaveBeenCalled();
 
       expect(authenticate).toHaveBeenCalledTimes(1);
       expect(authenticate).toHaveBeenCalledWith(mockRequest);
@@ -193,7 +193,7 @@ describe('setupAuthentication()', () => {
         responseHeaders: mockAuthResponseHeaders,
       });
       expect(mockResponse.redirected).not.toHaveBeenCalled();
-      expect(mockResponse.unauthorized).not.toHaveBeenCalled();
+      expect(mockResponse.internalError).not.toHaveBeenCalled();
 
       expect(authenticate).toHaveBeenCalledTimes(1);
       expect(authenticate).toHaveBeenCalledWith(mockRequest);
@@ -210,7 +210,7 @@ describe('setupAuthentication()', () => {
         headers: { location: '/some/url' },
       });
       expect(mockAuthToolkit.authenticated).not.toHaveBeenCalled();
-      expect(mockResponse.unauthorized).not.toHaveBeenCalled();
+      expect(mockResponse.internalError).not.toHaveBeenCalled();
     });
 
     it('rejects with `Internal Server Error` when `authenticate` throws unhandled exception', async () => {
@@ -219,8 +219,8 @@ describe('setupAuthentication()', () => {
 
       await authHandler(httpServerMock.createKibanaRequest(), mockResponse, mockAuthToolkit);
 
-      expect(mockResponse.unauthorized).toHaveBeenCalledTimes(1);
-      const [[error]] = mockResponse.unauthorized.mock.calls;
+      expect(mockResponse.internalError).toHaveBeenCalledTimes(1);
+      const [[error]] = mockResponse.internalError.mock.calls;
       expect(String(error)).toBe('Error: something went wrong');
       expect(getErrorStatusCode(error)).toBe(500);
 

diff --git a/x-pack/plugins/security/server/authentication/index.ts b/x-pack/plugins/security/server/authentication/index.ts
@@ -88,7 +88,7 @@ export async function setupAuthentication({
       authenticationResult = await authenticator.authenticate(request);
     } catch (err) {
       authLogger.error(err);
-      return response.unauthorized(wrapError(err));
+      return response.internalError(wrapError(err));
     }
 
     if (authenticationResult.succeeded()) {