Upgrade axios to v1.4 #162661
Assignees
Labels
Team:Operations
Team label for Operations Team
Comments
|
Pinging @elastic/kibana-operations (Team:Operations) |
delanni
added a commit
that referenced
this issue
Aug 22, 2023
## Summary upgrade `axios` to 1.4 - adjust to header usage, and config optionality - Axios' adapters are now resolved from a string key by axios, no need to import/instantiate adapters - most of the changed code stems from changes in Axios' types - `response.config` is now optional - there was a change in the type of AxiosHeaders <-> InternalAxiosHeaders Closes: #162661 Closes: #162414 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Aug 22, 2023
## Summary upgrade `axios` to 1.4 - adjust to header usage, and config optionality - Axios' adapters are now resolved from a string key by axios, no need to import/instantiate adapters - most of the changed code stems from changes in Axios' types - `response.config` is now optional - there was a change in the type of AxiosHeaders <-> InternalAxiosHeaders Closes: elastic#162661 Closes: elastic#162414 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 9d2696b)
kibanamachine
added a commit
that referenced
this issue
Aug 22, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [[Ops] Upgrade to axios 1.4 (#163732)](#163732) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2023-08-22T09:47:48Z","message":"[Ops] Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Team:APM","release_note:skip","backport:prev-MAJOR","v7.17.13","v8.11.0"],"number":163732,"url":"#163732 Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"7.17","label":"v7.17.13","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"#163732 Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
delanni
added a commit
to delanni/kibana
that referenced
this issue
Aug 22, 2023
upgrade `axios` to 1.4 - adjust to header usage, and config optionality - Axios' adapters are now resolved from a string key by axios, no need to import/instantiate adapters - most of the changed code stems from changes in Axios' types - `response.config` is now optional - there was a change in the type of AxiosHeaders <-> InternalAxiosHeaders Closes: elastic#162661 Closes: elastic#162414 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 9d2696b)
delanni
added a commit
that referenced
this issue
Aug 23, 2023
# Backport This will backport the following commits from `main` to `7.17`: - [[Ops] Upgrade to axios 1.4 (#163732)](#163732) <!--- Backport version: 8.9.8 ---> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2023-08-22T09:47:48Z","message":"[Ops] Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Team:APM","release_note:skip","backport:prev-MAJOR","v8.10.0","v7.17.13","v8.11.0"],"number":163732,"url":"#163732 Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"#164409 [Ops] Upgrade to axios 1.4 (#163732) (#164409)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.10`:\n- [[Ops] Upgrade to axios 1.4\n(#163732)](#163732 Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Alex\nSzabo\",\"email\":\"alex.szabo@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2023-08-22T09:47:48Z\",\"message\":\"[Ops]\nUpgrade to axios 1.4 (#163732)\\n\\n## Summary\\r\\nupgrade `axios` to\n1.4\\r\\n\\r\\n- adjust to header usage, and config optionality\\r\\n- Axios'\nadapters are now resolved from a string key by axios, no need\\r\\nto\nimport/instantiate adapters\\r\\n- most of the changed code stems from\nchanges in Axios' types\\r\\n - `response.config` is now optional\\r\\n-\nthere was a change in the type of AxiosHeaders\n<->\\r\\nInternalAxiosHeaders\\r\\n\\r\\nCloses: #162661 \\r\\nCloses:\n#162414\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Kibana Machine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"9d2696b5c5159870cecf02c9f23090b26c924c87\",\"branchLabelMapping\":{\"^v8.11.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Team:Operations\",\"Team:APM\",\"release_note:skip\",\"backport:prev-MAJOR\",\"v7.17.13\",\"v8.11.0\"],\"number\":163732,\"url\":\"#163732 to axios 1.4 (#163732)\\n\\n## Summary\\r\\nupgrade `axios` to\n1.4\\r\\n\\r\\n- adjust to header usage, and config optionality\\r\\n- Axios'\nadapters are now resolved from a string key by axios, no need\\r\\nto\nimport/instantiate adapters\\r\\n- most of the changed code stems from\nchanges in Axios' types\\r\\n - `response.config` is now optional\\r\\n-\nthere was a change in the type of AxiosHeaders\n<->\\r\\nInternalAxiosHeaders\\r\\n\\r\\nCloses: #162661 \\r\\nCloses:\n#162414\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Kibana Machine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"9d2696b5c5159870cecf02c9f23090b26c924c87\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"7.17\"],\"targetPullRequestStates\":[{\"branch\":\"7.17\",\"label\":\"v7.17.13\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.11.0\",\"labelRegex\":\"^v8.11.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"#163732 to axios 1.4 (#163732)\\n\\n## Summary\\r\\nupgrade `axios` to\n1.4\\r\\n\\r\\n- adjust to header usage, and config optionality\\r\\n- Axios'\nadapters are now resolved from a string key by axios, no need\\r\\nto\nimport/instantiate adapters\\r\\n- most of the changed code stems from\nchanges in Axios' types\\r\\n - `response.config` is now optional\\r\\n-\nthere was a change in the type of AxiosHeaders\n<->\\r\\nInternalAxiosHeaders\\r\\n\\r\\nCloses: #162661 \\r\\nCloses:\n#162414\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Kibana Machine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"9d2696b5c5159870cecf02c9f23090b26c924c87\"}}]}]\n\nCo-authored-by: Alex Szabo <alex.szabo@elastic.co>"}},{"branch":"7.17","label":"v7.17.13","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"#163732 Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are using an outdated version of axios that does not work well behind an http proxy. There were a community PR opened for this but it sill requires some considerable amount of work to be finished so it's better to have it on our roadmap as a thing to do.
The text was updated successfully, but these errors were encountered: