[Ops] Upgrade to axios 1.4 #163732
Merged
[Ops] Upgrade to axios 1.4 #163732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
force-pushed
the
kib-162661-upgrade-axios
branch
2 times, most recently
from
9848598
to
3a9a03c
Compare
|
@elasticmachine merge upstream |
delanni
force-pushed
the
kib-162661-upgrade-axios
branch
from
5ae1a0f
to
794be75
Compare
delanni
force-pushed
the
kib-162661-upgrade-axios
branch
from
70289f2
to
604fb34
Compare
|
@elasticmachine merge upstream |
|
Pinging @elastic/apm-ui (Team:APM) |
delanni
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
delanni
added
the
backport:prev-MAJOR
1 task
jbudz
approved these changes
Aug 15, 2023
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
machadoum
approved these changes
Aug 22, 2023
|
Thanks everyone for your attention and reviews! 🚀 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 22, 2023
## Summary upgrade `axios` to 1.4 - adjust to header usage, and config optionality - Axios' adapters are now resolved from a string key by axios, no need to import/instantiate adapters - most of the changed code stems from changes in Axios' types - `response.config` is now optional - there was a change in the type of AxiosHeaders <-> InternalAxiosHeaders Closes: elastic#162661 Closes: elastic#162414 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 9d2696b)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 22, 2023
# Backport This will backport the following commits from `main` to `8.10`: - [[Ops] Upgrade to axios 1.4 (#163732)](#163732) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2023-08-22T09:47:48Z","message":"[Ops] Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Team:APM","release_note:skip","backport:prev-MAJOR","v7.17.13","v8.11.0"],"number":163732,"url":"#163732 Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"7.17","label":"v7.17.13","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"#163732 Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
delanni
added a commit
to delanni/kibana
that referenced
this pull request
Aug 22, 2023
upgrade `axios` to 1.4 - adjust to header usage, and config optionality - Axios' adapters are now resolved from a string key by axios, no need to import/instantiate adapters - most of the changed code stems from changes in Axios' types - `response.config` is now optional - there was a change in the type of AxiosHeaders <-> InternalAxiosHeaders Closes: elastic#162661 Closes: elastic#162414 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 9d2696b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
delanni
added a commit
that referenced
this pull request
Aug 23, 2023
# Backport This will backport the following commits from `main` to `7.17`: - [[Ops] Upgrade to axios 1.4 (#163732)](#163732) <!--- Backport version: 8.9.8 ---> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2023-08-22T09:47:48Z","message":"[Ops] Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Team:APM","release_note:skip","backport:prev-MAJOR","v8.10.0","v7.17.13","v8.11.0"],"number":163732,"url":"#163732 Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"#164409 [Ops] Upgrade to axios 1.4 (#163732) (#164409)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.10`:\n- [[Ops] Upgrade to axios 1.4\n(#163732)](#163732 Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Alex\nSzabo\",\"email\":\"alex.szabo@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2023-08-22T09:47:48Z\",\"message\":\"[Ops]\nUpgrade to axios 1.4 (#163732)\\n\\n## Summary\\r\\nupgrade `axios` to\n1.4\\r\\n\\r\\n- adjust to header usage, and config optionality\\r\\n- Axios'\nadapters are now resolved from a string key by axios, no need\\r\\nto\nimport/instantiate adapters\\r\\n- most of the changed code stems from\nchanges in Axios' types\\r\\n - `response.config` is now optional\\r\\n-\nthere was a change in the type of AxiosHeaders\n<->\\r\\nInternalAxiosHeaders\\r\\n\\r\\nCloses: #162661 \\r\\nCloses:\n#162414\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Kibana Machine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"9d2696b5c5159870cecf02c9f23090b26c924c87\",\"branchLabelMapping\":{\"^v8.11.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"Team:Operations\",\"Team:APM\",\"release_note:skip\",\"backport:prev-MAJOR\",\"v7.17.13\",\"v8.11.0\"],\"number\":163732,\"url\":\"#163732 to axios 1.4 (#163732)\\n\\n## Summary\\r\\nupgrade `axios` to\n1.4\\r\\n\\r\\n- adjust to header usage, and config optionality\\r\\n- Axios'\nadapters are now resolved from a string key by axios, no need\\r\\nto\nimport/instantiate adapters\\r\\n- most of the changed code stems from\nchanges in Axios' types\\r\\n - `response.config` is now optional\\r\\n-\nthere was a change in the type of AxiosHeaders\n<->\\r\\nInternalAxiosHeaders\\r\\n\\r\\nCloses: #162661 \\r\\nCloses:\n#162414\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Kibana Machine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"9d2696b5c5159870cecf02c9f23090b26c924c87\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"7.17\"],\"targetPullRequestStates\":[{\"branch\":\"7.17\",\"label\":\"v7.17.13\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.11.0\",\"labelRegex\":\"^v8.11.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"#163732 to axios 1.4 (#163732)\\n\\n## Summary\\r\\nupgrade `axios` to\n1.4\\r\\n\\r\\n- adjust to header usage, and config optionality\\r\\n- Axios'\nadapters are now resolved from a string key by axios, no need\\r\\nto\nimport/instantiate adapters\\r\\n- most of the changed code stems from\nchanges in Axios' types\\r\\n - `response.config` is now optional\\r\\n-\nthere was a change in the type of AxiosHeaders\n<->\\r\\nInternalAxiosHeaders\\r\\n\\r\\nCloses: #162661 \\r\\nCloses:\n#162414\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by: Kibana Machine\n<42973632+kibanamachine@users.noreply.github.com>\",\"sha\":\"9d2696b5c5159870cecf02c9f23090b26c924c87\"}}]}]\n\nCo-authored-by: Alex Szabo <alex.szabo@elastic.co>"}},{"branch":"7.17","label":"v7.17.13","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"#163732 Upgrade to axios 1.4 (#163732)\n\n## Summary\r\nupgrade `axios` to 1.4\r\n\r\n- adjust to header usage, and config optionality\r\n- Axios' adapters are now resolved from a string key by axios, no need\r\nto import/instantiate adapters\r\n- most of the changed code stems from changes in Axios' types\r\n - `response.config` is now optional\r\n- there was a change in the type of AxiosHeaders <->\r\nInternalAxiosHeaders\r\n\r\nCloses: #162661 \r\nCloses: #162414\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"9d2696b5c5159870cecf02c9f23090b26c924c87"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
upgrade
axiosto 1.4response.configis now optionalCloses: #162661
Closes: #162414