Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @testing-library #128659

Merged
merged 14 commits into from
Apr 6, 2022
Merged

Bump @testing-library #128659

merged 14 commits into from
Apr 6, 2022

Conversation

patrykkopycinski
Copy link
Contributor

No description provided.

@patrykkopycinski patrykkopycinski marked this pull request as ready for review March 31, 2022 06:54
@patrykkopycinski patrykkopycinski requested a review from a team March 31, 2022 06:54
@patrykkopycinski patrykkopycinski requested review from a team as code owners March 31, 2022 06:54
@patrykkopycinski patrykkopycinski self-assigned this Mar 31, 2022
@patrykkopycinski patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels Mar 31, 2022
tomsonpl
tomsonpl reviewed Mar 31, 2022
View reviewed changes
...k/plugins/security_solution/public/timelines/components/timeline/properties/helpers.test.tsx
expect(spy).toHaveBeenCalled();
waitFor(() => {
wrapper.simulate('click');
expect(spy).toHaveBeenCalled();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the expect be outside of waitFor() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://testing-library.com/docs/dom-testing-library/api-async/#waitfor

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Mar 31, 2022
afgomez
afgomez approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unified observability changes LGTM

opauloh
opauloh approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Session View changes - LGTM!

justinkambic
justinkambic approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uptime changes LGTM

@patrykkopycinski patrykkopycinski requested a review from a team April 5, 2022 13:58
jbudz
jbudz reviewed Apr 5, 2022
View reviewed changes
package.json Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 3026 2781 -245

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.9MB 4.8MB -42.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.8MB 3.8MB -686.0B
securitySolution 251.6KB 251.6KB +1.0B
total -685.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski merged commit 3dc66c6 into elastic:main Apr 6, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 6, 2022
@patrykkopycinski patrykkopycinski deleted the chore/renovate-testing-library branch April 6, 2022 19:11
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsonpl tomsonpl tomsonpl left review comments

@afgomez afgomez afgomez approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@jbudz jbudz jbudz approved these changes

@cnasikas cnasikas cnasikas approved these changes

@justinkambic justinkambic justinkambic approved these changes

@opauloh opauloh opauloh approved these changes

@spalger spalger Awaiting requested review from spalger

Assignees

@patrykkopycinski patrykkopycinski

Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet