-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Puppeteer v18 #141031
base: main
Are you sure you want to change the base?
Puppeteer v18 #141031
Conversation
fix revision and checksums for mac & windows
@elasticmachine merge upstream |
merge conflict between base and head |
@elasticmachine merge upstream |
return undefined; | ||
/* !! End of browser context !! */ | ||
}, arg); | ||
const errorMessage = await arg.executionContext().evaluate((_arg: unknown) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we don't use the .evaluateContext()
part any longer:
https://github.com/puppeteer/puppeteer/blob/v18.0.2/docs/api/puppeteer.jshandle.evaluate.md
const errorMessage = await arg.executionContext().evaluate((_arg: unknown) => { | |
const errorMessage = await arg.evaluate((_arg: unknown) => { |
Puppeteer v18
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
The type check errors seem to be due to puppeteer/puppeteer#8986 |
All of the changes related to build-improvement are handled in this PR: #143022 |
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers