Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer v18 #141031

Draft
wants to merge 51 commits into
base: main
Choose a base branch
from
Draft

Puppeteer v18 #141031

wants to merge 51 commits into from

Conversation

vadimkibana
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@vadimkibana vadimkibana added ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment labels Sep 20, 2022
@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@vadimkibana
Copy link
Contributor Author

@elasticmachine merge upstream

return undefined;
/* !! End of browser context !! */
}, arg);
const errorMessage = await arg.executionContext().evaluate((_arg: unknown) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't use the .evaluateContext() part any longer:
https://github.com/puppeteer/puppeteer/blob/v18.0.2/docs/api/puppeteer.jshandle.evaluate.md

Suggested change
const errorMessage = await arg.executionContext().evaluate((_arg: unknown) => {
const errorMessage = await arg.evaluate((_arg: unknown) => {

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 5, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / ensureDownloaded when archives are already present should not download again
  • [job] [logs] Jest Integration Tests #1 / POST /diagnose/screenshot catches errors and returns a well formed response
  • [job] [logs] Jest Integration Tests #1 / POST /diagnose/screenshot returns a 200 by default
  • [job] [logs] Jest Integration Tests #1 / POST /diagnose/screenshot returns a 200 when it fails and sets success to false

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 58.6KB 58.9KB +300.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
reporting 4 6 +2

Total ESLint disabled count

id before after diff
reporting 5 7 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan
Copy link
Member

The type check errors seem to be due to puppeteer/puppeteer#8986

@tsullivan tsullivan mentioned this pull request Oct 5, 2022
9 tasks
@tsullivan
Copy link
Member

All of the changes related to build-improvement are handled in this PR: #143022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants