Upgrade ESLint to v8 #162309

watson · 2023-07-20T09:52:44Z

For details of breaking changes, see ESLint blog post Migrate to v8.0.0. For a full list of changes see their CHANGELOG.md.

The newer version comes with various performance improvements, but I haven't tested if it's significant in a project like ours.

The PR also upgrades a bunch of ESLint plugins and related packages at the same time. Some of these upgrades probably wasn't required to complete the v8 upgrade, though I haven't verified - but YOLO 😅

Updated direct dependencies

Package	From	To	Changes
`@types/eslint`	7.28.0	8.44.2
`eslint`	7.32.0	8.46.0	`CHANGELOG.md`
`eslint-config-prettier`	8.5.0	9.0.0	`CHANGELOG.md`
`eslint-module-utils`	2.6.2	2.8.0	`CHANGELOG.md`
`eslint-plugin-ban`	1.5.2	1.6.0	diff
`eslint-plugin-cypress`	2.13.2	2.14.0	Release notes
`eslint-plugin-import`	2.24.2	2.28.0	`CHANGELOG.md`
`eslint-plugin-jsx-a11y`	6.4.1	6.7.1	`CHANGELOG.md`
`eslint-plugin-mocha`	10.0.5	10.1.0	`CHANGELOG.md`
`eslint-plugin-no-unsanitized`	3.1.5	4.0.2	diff

Note to reviewers

The vast majority of files touched by this PR is changes to the import order due to minor fixes in the import/order rule.

Blocked by

Tasks

Give feedback

Clean up imports of ESLint types #162436

Team:Operations backport:skip release_note:skip v8.10.0 v8.9.1
Edit...
Successfully updated the issue's project

There was an error updating the issue's project
Remove eslint-plugin-prefer-object-spread dependency #162439

Team:Operations release_note:skip v7.17.13 v8.10.0 v8.9.1
Edit...
Successfully updated the issue's project

There was an error updating the issue's project
Upgrade ESLint React plugins #162464

Team:Operations Team:Uptime - DEPRECATED auto-backport release_note:skip v7.17.13 v8.10.0
Edit...
Successfully updated the issue's project

There was an error updating the issue's project
Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 #162689

Team:Operations backport:all-open release_note:skip v7.17.13 v8.10.0 v8.9.1
Edit...
Successfully updated the issue's project

There was an error updating the issue's project
Options

x-pack/plugins/security_solution/cypress/tasks/create_new_rule.ts

x-pack/plugins/security_solution/cypress/tasks/network/flows.ts

kibana-ci · 2023-08-10T09:03:28Z

💚 Build Succeeded

Buildkite Build
Commit: 3e996ed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`osquery`	1.0MB	1.0MB	-28.0B
`security`	567.8KB	567.8KB	+60.0B
`spaces`	173.8KB	173.8KB	+28.0B
total			+60.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-npmDll`	6.0MB	6.0MB	-4.0B
`security`	69.7KB	69.7KB	+1.0B
`spaces`	26.0KB	26.0KB	+10.0B
total			+7.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`security`	54	53	-1
`securitySolution`	462	464	+2
total			+1

Total ESLint disabled count

id	before	after	diff
`security`	56	55	-1
`securitySolution`	525	527	+2
total			+1

History

💛 Build #148902 was flaky be05071
💚 Build #148759 succeeded 47b6bc7
💔 Build #148680 failed 47ed3a8
💔 Build #145903 failed 13acf2e
💔 Build #145468 failed 2d86e72
💔 Build #145434 failed 57b4623

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

achyutjhunjhunwala

APM changes are good to go 👍🏼

tomsonpl

Defend Workflows LGTM, impressive effort, good luck with merging 🤞

patrykkopycinski

Thank you @watson 🙇

paul-tavares · 2023-08-10T14:22:51Z

Hey @tomsonpl , @patrykkopycinski ,
I added you to this PR since the files impacted for our team are OSQuery related. Can you take a look when you get a chance and 👍 it?

🙏

sphilipse

ent-search changes LGTM

stephmilovic

LGTM for explore changes

kibanamachine · 2023-08-10T22:40:54Z

💔 All backports failed

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts You might need to backport the following PRs to 7.17: - Upgrade re2 from v1.17.7 to v1.20.1 (#162880)

Manual backport

To create the backport manually run:

node scripts/backport --pr 162309

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

watson · 2023-08-14T10:59:43Z

Removed automatic backport labels due to manual backport in #163792

Upgrade eslint from 7.32.0 to 8.46.0. For details of breaking changes, see ESLint blog post, Migrate to v8.0.0: https://eslint.org/docs/latest/use/migrate-to-8.0.0 For a full list of changes see their CHANGELOG.md: https://github.com/eslint/eslint/blob/main/CHANGELOG.md This also upgrades a bunch of ESLint plugins and related packages at the same time: @types/eslint: 7.28.0 -> 8.44.2 eslint-config-prettier: 8.5.0 -> 9.0.0 eslint-module-utils: 2.6.2 -> 2.8.0 eslint-plugin-ban; 1.5.2 -> 1.6.0 eslint-plugin-cypress: 2.13.2 -> 2.14.0 eslint-plugin-import: 2.24.2 -> 2.28.0 eslint-plugin-jsx-a11y: 6.4.1 -> 6.7.1 eslint-plugin-mocha: 10.0.5 -> 10.1.0 eslint-plugin-no-unsanitized: 3.1.5 -> 4.0.2

watson added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 v7.17.12 labels Jul 20, 2023

watson self-assigned this Jul 20, 2023

watson force-pushed the bump-eslint branch 10 times, most recently from 31f130d to b2dd5b6 Compare July 24, 2023 19:25

watson mentioned this pull request Jul 24, 2023

Clean up imports of ESLint types #162436

Merged

watson force-pushed the bump-eslint branch 3 times, most recently from c7a6418 to e4b607d Compare July 25, 2023 11:43

watson mentioned this pull request Jul 25, 2023

Upgrade ESLint React plugins #162464

Merged

kpatticha added the apm:cypress-record cypress test runs will be recorded to the cypress dashboard label Jul 25, 2023

watson force-pushed the bump-eslint branch 2 times, most recently from f1a567b to 02f6c5c Compare July 28, 2023 08:55

watson mentioned this pull request Jul 28, 2023

Upgrade eslint-plugin-jest from v24.5.0 to v27.2.3 #162689

Merged

watson force-pushed the bump-eslint branch 2 times, most recently from 2d86e72 to 13acf2e Compare July 31, 2023 11:04

watson force-pushed the bump-eslint branch from 13acf2e to 72bf672 Compare August 9, 2023 10:15

watson added the auto-backport Deprecated: Automatically backport this PR after it's merged label Aug 9, 2023

watson force-pushed the bump-eslint branch from 47ed3a8 to 47b6bc7 Compare August 9, 2023 13:47

Upgrade eslint to v8

be05071

watson force-pushed the bump-eslint branch from 47b6bc7 to be05071 Compare August 9, 2023 18:00

watson added 3 commits August 10, 2023 09:30

Bump again to latest minor versions

f2bc111

Ignore cypress/unsafe-to-chain-command lint errors

2497ebd

bumps

3e996ed

watson requested a review from a team as a code owner August 10, 2023 07:57

watson commented Aug 10, 2023

View reviewed changes

x-pack/plugins/security_solution/cypress/tasks/create_new_rule.ts Show resolved Hide resolved

watson commented Aug 10, 2023

View reviewed changes

x-pack/plugins/security_solution/cypress/tasks/network/flows.ts Show resolved Hide resolved

watson mentioned this pull request Aug 10, 2023

Enable prefer-object-has-own ESLint rule #163572

Draft

achyutjhunjhunwala approved these changes Aug 10, 2023

View reviewed changes

tomsonpl approved these changes Aug 10, 2023

View reviewed changes

patrykkopycinski approved these changes Aug 10, 2023

View reviewed changes

paul-tavares requested review from patrykkopycinski and tomsonpl and removed request for paul-tavares August 10, 2023 14:22

sphilipse approved these changes Aug 10, 2023

View reviewed changes

stephmilovic approved these changes Aug 10, 2023

View reviewed changes

watson merged commit 99db840 into elastic:main Aug 10, 2023
29 checks passed

watson deleted the bump-eslint branch August 10, 2023 22:32

watson mentioned this pull request Aug 14, 2023

[7.17] Upgrade ESLint to v8 (#162309) #163792

Draft

watson removed auto-backport Deprecated: Automatically backport this PR after it's merged v7.17.13 labels Aug 14, 2023

kibanamachine added the backport:skip This commit does not require backporting label Aug 14, 2023

This was referenced Aug 15, 2023

Upgrade Node.js to 18.17.1 #163710

Merged

chore(deps): upgrade supertest and superagent #163716

Merged

kibanamachine mentioned this pull request Jan 26, 2024

Ensure all API Keys have a defined name #175721

Merged

kibanamachine mentioned this pull request Mar 13, 2024

fix(platform-security): allow customizing sub-feature privileges with all spaces requirement #178239

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade ESLint to v8 #162309

Upgrade ESLint to v8 #162309

watson commented Jul 20, 2023 •

edited

Tasks

kibana-ci commented Aug 10, 2023

ESLint disabled line counts

Total ESLint disabled count

achyutjhunjhunwala left a comment

tomsonpl left a comment

patrykkopycinski left a comment

paul-tavares commented Aug 10, 2023

sphilipse left a comment

stephmilovic left a comment

kibanamachine commented Aug 10, 2023

watson commented Aug 14, 2023

Upgrade ESLint to v8 #162309

Upgrade ESLint to v8 #162309

Conversation

watson commented Jul 20, 2023 • edited

Updated direct dependencies

Note to reviewers

Blocked by

Tasks

kibana-ci commented Aug 10, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

tomsonpl left a comment

Choose a reason for hiding this comment

patrykkopycinski left a comment

Choose a reason for hiding this comment

paul-tavares commented Aug 10, 2023

sphilipse left a comment

Choose a reason for hiding this comment

stephmilovic left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 10, 2023

💔 All backports failed

Manual backport

Questions ?

watson commented Aug 14, 2023

watson commented Jul 20, 2023 •

edited