Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Move TryInConsoleButton to it's own package #183201

Merged
merged 2 commits into from May 13, 2024

Conversation

TattdCodeMonkey
Copy link
Contributor

Summary

Moved the TryInConsoleButton from the search api panels package to its
own package. This should make it easier to import and encourage usage in
more parts of Kibana even outside of search.

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0 labels May 10, 2024
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner May 10, 2024 21:16
Moved the TryInConsoleButton from the search api panels package to its
own package. This should make it easier to import and encourage usage in
more parts of Kibana even outside of search.
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2277 2278 +1
indexManagement 659 660 +1
serverlessSearch 318 319 +1
total +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-api-panels 84 74 -10
@kbn/try-in-console - 2 +2
total -8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.7MB -531.0B
indexManagement 662.9KB 662.8KB -73.0B
serverlessSearch 471.2KB 471.1KB -76.0B
total -680.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/try-in-console - 1 +1
Unknown metric groups

API count

id before after diff
@kbn/search-api-panels 84 74 -10
@kbn/try-in-console - 2 +2
total -8

ESLint disabled line counts

id before after diff
@kbn/try-in-console - 1 +1

Total ESLint disabled count

id before after diff
@kbn/try-in-console - 1 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TattdCodeMonkey TattdCodeMonkey merged commit 98329a8 into elastic:main May 13, 2024
34 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 13, 2024
@TattdCodeMonkey TattdCodeMonkey deleted the rnorris/tic-btn-package branch May 13, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants