Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset Quality] Reactive Estimated Data Panel #183218

Conversation

mohamedhamed-ahmed
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented May 12, 2024

closes #182873

📝 Summary

After implementing #179172 its now time to make the Estimated Data panel reactive to all table filters as well.

This PR is the last step into making the summary panel reactive to all table filters. As part of the implementation the following has been done:

  1. The summary panel state machine is completely removed as its no longer needed and we now rely on the dataset quality state machine.
  2. The Estimated Size panel is now reactive to all filters and show a sum of the dataset sizes displayed in the table.
  3. The Size column now shows the size for each dataset within the given time range.
  4. The Size column and the Estimated data panel are now both hidden on serverless as they both rely on the stats API which is not yet available on serverless.
  5. As part of this ticket [Dataset quality] Replaced Estimated Data section by doc count in serverless deployments #180582 we should start showing the number of docs instead of the size on serverless.

🎥 Demo

Screen.Recording.2024-05-14.at.12.01.44.mov

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mohamedhamed-ahmed mohamedhamed-ahmed added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-logs Observability Logs User Experience Team v8.15.0 labels May 12, 2024
@yngrdyn yngrdyn self-requested a review May 14, 2024 08:12
@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review May 14, 2024 10:03
@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team as a code owner May 14, 2024 10:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label May 14, 2024
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nits

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 14, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
datasetQuality 193 187 -6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 180.9KB 179.4KB -1.5KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5407 +5407
total size - 8.8MB +8.8MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 36.8KB 36.7KB -115.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mohamedhamed-ahmed mohamedhamed-ahmed merged commit f33b662 into elastic:main May 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dataset quality] Reactive Estimated Data Summary Panel
6 participants