Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ts-jest #24149

Closed
wants to merge 1 commit into from
Closed

Upgrade ts-jest #24149

wants to merge 1 commit into from

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Oct 17, 2018

I was having issues with line numbers matching up in interactive debugging sessions with the old version. Simply bumping to the latest seems to fix the issue for me.

@Bargs Bargs added review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Oct 17, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

mistic
mistic approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic
Copy link
Member

mistic commented Oct 19, 2018

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@Bargs
Copy link
Contributor Author

Bargs commented Oct 19, 2018

Thank you for the review @mistic ! Now if only we could get Jenkins to behave :(

@Bargs
Copy link
Contributor Author

Bargs commented Oct 23, 2018

jenkins, test this

@azasypkin
Copy link
Member

ERROR node_modules/ts-jest/dist/types.d.ts:2:25 - error TS2307: Cannot find module 'babel__core'. looks like a legit issue that's related to the PR.

@Bargs
Copy link
Contributor Author

Bargs commented Oct 23, 2018

Anyone have a clue what that means?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mistic
Copy link
Member

mistic commented Oct 23, 2018

Mr @Bargs I think it has todo with this issue here: DefinitelyTyped/DefinitelyTyped#27729 and more concretely with microsoft/types-publisher#502

When it get solved I think you'll be able to make the build pass (there is also a possibility that even after the issue get solved you'll have to run yarn add -D @types/babel__core due to another issue in ts-jest kulshekhar/ts-jest#782 but I'm not sure yet) 😄

@azasypkin
Copy link
Member

// cleaning up my review queue, feel free to re-request review whenever you need it.

@azasypkin azasypkin removed their request for review November 2, 2018 09:52
@mistic
Copy link
Member

mistic commented Dec 3, 2018

@Bargs one of the PRs opened to solve that issue was closed. Do you wanna merge your PR branch with master and try to test it again?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger spalger removed their request for review December 7, 2018 17:48
@Bargs
Copy link
Contributor Author

Bargs commented Dec 14, 2018

Rebased and pushed, let's see how it goes.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@mistic
Copy link
Member

mistic commented Mar 29, 2019

@Bargs I'm going to close this one! Since we moved to Babel 7 and @babel/preset-typescript here #33027 we don't use ts-jest anymore. Instead we are running typescript jest tests with babel-jest 😄

@mistic mistic closed this Mar 29, 2019
@Bargs
Copy link
Contributor Author

Bargs commented Mar 29, 2019

yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bargs @elasticmachine @mistic @azasypkin