Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logstash] [Pipeline Viewer] Improve LS monitoring accessibility #24169

Merged
merged 4 commits into from
Oct 18, 2018
Merged

[Logstash] [Pipeline Viewer] Improve LS monitoring accessibility #24169

merged 4 commits into from
Oct 18, 2018

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #18065

The accessibility of the Pipeline Viewer was already greatly improved with the changes we added in #18597 for 6.4.0, but it can be improved with the proper addition of aria-labels for the buttons on the view.

With regards to tab order, @snide and I confirmed that everything looks fine with it, and it should because the view is composed exclusively of EUI components.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11 All the components in question are EUI-maintained
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support No text was added, the labels use the name fields.
- [ ] Documentation was added for features that require explanation or tutorials No functionality was added, aside from increasing the utility of screen readers

For maintainers

Testing this PR

The updated snapshots should demonstrate the needed labels being rendered, but if you want to actually see the view rendering these I'm happy to help stand up a LS instance.

Alternatively, here's an example of each of the button types rendering the appropriate aria-label attribute:

  • Plugin Statement:
    image
  • Collapsible Statement Icon Button:
    image
  • Collapsible Statement Name button:
    image

cc @AlonaNadler

snide
snide approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@elasticmachine
Copy link
Contributor

💔 Build Failed

@justinkambic
Copy link
Contributor Author

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic justinkambic merged commit 2b6cd21 into elastic:master Oct 18, 2018
justinkambic added a commit that referenced this pull request Oct 18, 2018
@justinkambic
[Logstash] [Pipeline Viewer] Improve LS monitoring accessibility (#24169
de08f17 
)

* Update test data shape to conform to component proptypes.

* Add aria-labels for pipeline viewer buttons.
@justinkambic justinkambic deleted the monitoring_ls-pipeline-viewer-accessibility branch October 18, 2018 16:46
@justinkambic
Copy link
Contributor Author

Backported to:
6.x/6.5.0 de08f17

skh added a commit to skh/kibana that referenced this pull request Oct 22, 2018
@skh
Squashed commit of the following:
7ec8e03 
commit 7739410
Author: markharwood <markharwood@gmail.com>
Date:   Mon Oct 22 09:30:16 2018 +0100

    Graph fix: Remove “step” property which makes values other than 1, 1001, 2001 etc illegal (elastic#23610)

    Closes elastic#22054

commit 3ca2231
Author: markharwood <markharwood@gmail.com>
Date:   Mon Oct 22 09:27:17 2018 +0100

    Remove “step” property which makes values other than 1, 1001, 2001 etc illegal (elastic#23610)

    Closes elastic#22054

commit 98f7667
Author: Andrew Wilkins <axwalk@gmail.com>
Date:   Mon Oct 22 08:54:46 2018 +0800

    [APM] Update Go agent instructions (elastic#24111)

    - Update the Go agent instructions to refer to the new import path.
    - Change some of the wording to align with other agents.
    - Drop "beta" warning.

commit f6ba696
Author: Maryia Lapata <mary.lopato@gmail.com>
Date:   Sun Oct 21 15:39:15 2018 +0300

    Fix broken link on Watcher (elastic#24317)

commit 3fc8b35
Author: Josh Dover <me@joshdover.com>
Date:   Sat Oct 20 10:45:14 2018 -0500

    Add server OS information to telemetry stats (elastic#23793)

    * Add server OS data to monitoring collector and telemetry

    * Fixup naming

    * Fix functional tests

commit 9904bd9
Author: Spencer <email@spalger.com>
Date:   Fri Oct 19 20:29:38 2018 -0700

    [uiSettings] upgrade old config on read (elastic#24108)

    * doing config migration during config get if necessary

    * fixing issue with writing new config when user does not have write privilege

    * [uiSettings] only log about config upgrade on success

    * [uiSettings/createOrUpgradeSavedConfig] add onWriteError option

    * [uiSettings] return the upgradeAttributes if reader is unable to write upgrade

    * [uiSettings] update route tests to cover upgrade on get

    * [spaces/integration-tests] add config doc to expected objects

    * [uiSettings] avoid shadowed variable name

commit ab29946
Author: dave.snider@gmail.com <dave.snider@gmail.com>
Date:   Fri Oct 19 18:30:06 2018 -0700

    update eui to 4.5.1 (elastic#24218)

    * update eui to 4.5.1

    * icons declared for logging / infra

    * remove eui types that are now in EUI directly

    * clean up duplicated EUI typescript definitions

    * Fix EuiSelect usage in beats enrollment

commit 6b4b0fe
Author: Tyler Smalley <tylersmalley@me.com>
Date:   Fri Oct 19 17:15:29 2018 -0700

    Updates build file unit tests to be Windows Compatible (elastic#24296)

    POSTIX permissions are not available on windows and libuv reports only
    666 and 444 for if it's read or writeable.

    Additionally, on Windows and being reported on OSX, modifying directory
    timestamps in the same stream often does not work.

    Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

commit 8ee620d
Author: Tim Sullivan <tsullivan@users.noreply.github.com>
Date:   Fri Oct 19 15:44:23 2018 -0700

    Add note about automatic inclusion of all stats (elastic#24309)

commit 208bd51
Author: Spencer <email@spalger.com>
Date:   Fri Oct 19 15:28:12 2018 -0700

    [core/public/chrome] migrate controls, theme, and visibility apis (elastic#22987)

    * [core/public/chrome] migrate controls, theme, and visibility apis

    * [core/public] stop uiSettings service

    * [core/public/chrome] test that observables stop immedaiately after stop()

    * fix typos

    * [core/public/legacyPlatform] test globalNavState init

    * [ui/chrome] don't pass extra params

    * [core/public/chrome] test for dedupe-handling

    * [ui/chrome/theme] test with different values for logo and smallLogo

commit 2fa5ee5
Author: Josh Dover <me@joshdover.com>
Date:   Fri Oct 19 17:22:54 2018 -0500

    Add euiIconType for InfraOps and Logs links (elastic#24289)

commit 938d130
Author: Tyler Smalley <tylersmalley@me.com>
Date:   Fri Oct 19 15:10:27 2018 -0700

    Updates file unit tests to be Windows compatible (elastic#24281)

    Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

commit bd3f840
Author: Tim Sullivan <tsullivan@users.noreply.github.com>
Date:   Fri Oct 19 15:00:38 2018 -0700

    [docs/reporting] note about data table pdf (elastic#23921)

commit 9189c06
Author: Chris Cowan <chris@chriscowan.us>
Date:   Fri Oct 19 13:54:58 2018 -0700

    [Infra UI] Test for waffle map GraphQL endpoint (elastic#24184)

    * [Infra UI] Test for metrics GraphQL endpoint

    * Moving apollo-boost to devDeps

    * Converting tests to typescript

    * Renaming infraops to infra

    * Converting to typescript

    * renaming from infraops to infra

    * Adding waffle tests back in

commit 73d8bb9
Author: Peter Pisljar <peter.pisljar@gmail.com>
Date:   Fri Oct 19 20:40:05 2018 +0200

    always start with closed context menu (elastic#24252)

commit d8d2a18
Author: Nox911 <nox.911@gmail.com>
Date:   Fri Oct 19 21:02:58 2018 +0300

    Translations for Management -> Objects (elastic#23905)

    * fix tests and update snapshots

    * fix id names

    * fix test and update snapshots

    * Update unit test snapshots

    * fix issues

    * Update snapshots

    * Fix issues

commit 371eca2
Author: Nox911 <nox.911@gmail.com>
Date:   Fri Oct 19 20:56:50 2018 +0300

    Translations for Advanced Settings (elastic#23881)

    * translate kbn.management.advanced_settings

    * fix tests and update snapshots

    * fix tests

    * fix  issues

    * fix id in get_category-name.js

    * Update unit test snapshot

    * update snapshot

    * Fix issues

commit a5c28d5
Author: Nox911 <nox.911@gmail.com>
Date:   Fri Oct 19 20:49:37 2018 +0300

    Feature/translate watcher(part_3) (elastic#24066)

    * translate watcher(part_3)

    * fix default message in monitoring_watch.js

    * fix issues

    * fix issues

    * fix issues

    * fix issues

commit fa95143
Author: Nox911 <nox.911@gmail.com>
Date:   Fri Oct 19 20:48:31 2018 +0300

    Feature/translate watcher(part_2) (elastic#24017)

    * translate watcher(pad_2)

    * fix issues

    * fix issues

commit 6247189
Author: Nox911 <nox.911@gmail.com>
Date:   Fri Oct 19 20:47:05 2018 +0300

    Feature/translate watcher(part_1) (elastic#23989)

    * translate watcher(pad_1)

    * fix test

    * fix issues

    * fix the same id name

    * fix default message

    * fix issues

commit 3c15067
Author: Chris Cowan <chris@chriscowan.us>
Date:   Fri Oct 19 10:39:21 2018 -0700

    [Infra UI] Test for metrics GraphQL endpoint (elastic#24179)

    * [Infra UI] Test for metrics GraphQL endpoint

    * Moving apollo-boost to devDeps

    * Converting tests to typescript

    * Renaming infraops to infra

commit c5e61c3
Author: Stacey Gammon <gammon@elastic.co>
Date:   Fri Oct 19 13:21:12 2018 -0400

    EAH - Typescript state_monitor_factory (elastic#23945)

    * Typescript state_monitor_factory

    * Fix linter error with possibly undefined

    * Expand typings to include hash stuff and expand the State type definition more.

    * Mark readonly

commit cc75547
Author: tibmt <pavelyukhnevich@yandex.ru>
Date:   Fri Oct 19 18:25:55 2018 +0300

    Translate Gauge and Goal (elastic#23882)

    * Translate Gauge and Goal

    * fix some names, rewrite some code and add 'kbnVislibVisTypes' to '.i18nrc.json'

    * add 'Required' translation

    * fix 'requiredText' bug

    * use \' instead of &quot;

    * update heatmap component

    * Update gauge.js

    * Update gauge.js

    * Update gauge.js

commit 4b9e13c
Author: Maryia Lapata <mary.lopato@gmail.com>
Date:   Fri Oct 19 17:59:07 2018 +0300

    Init I18n before Notifications start (elastic#23902)

    * Init I18n before Notifications start

    * Remove i18n initialization in AngularJS since it will be already initialized in CoreSystem

    * Remove unused translationsApi

    * Remove redundant i18n.init invocation

    * Remove i18n tests since  i18n.init was removed and input params for AppBootstrap were changed

    * Move i18n initialization to the entry file.

commit 03d14a7
Author: Bill McConaghy <bill.mcconaghy@elastic.co>
Date:   Fri Oct 19 10:48:41 2018 -0400

    fixing mangling of floating point numbers by console (elastic#23685)

    * fixing mangling of floating point numbers by console

    * fixing tests

    * fixing issue with large requests

    * restoring old code for server side as it handles large responses better

commit a23124e
Author: Matt Apperson <me@mattapperson.com>
Date:   Fri Oct 19 10:17:45 2018 -0400

    [BeatsCM] Fixes and issue where if security is disabled, BeatsCM breaks Kibana (elastic#24249)

    * fix spelling

    * fix license and security checks

    * removed unused vars

    * cleanup

    * remove security check from route def as it is already managed in-route

commit da26fcb
Author: Melissa Alvarez <melissa.alvarez@elastic.co>
Date:   Fri Oct 19 09:42:21 2018 +0100

    [ML] Ensure applying/removing groups menu is keyboard accessible (elastic#24212)

    * add group list arrow nav

    * up/down moved into own functions

    * always prevent default on arrow key press

commit db905c0
Author: dave.snider@gmail.com <dave.snider@gmail.com>
Date:   Thu Oct 18 18:12:39 2018 -0700

    remove eui css import from beats/infra (elastic#24245)

commit 314d1c4
Author: Lukas Olson <olson.lukas@gmail.com>
Date:   Thu Oct 18 13:37:44 2018 -0700

    Canvas function/argument/value autocomplete (elastic#23200)

    * feat: canvas autocomplete

    * fix: remove unused files

    * autocomplete ui cleanup

    * fix: handle stuff inside quotes

    * fix: canvas suggestion comparator

    * fix: spaces at the beginning of expressions

    * fix: move header out of autocomplete component itself

    * fix: add tests

    * fix: failing test

    * fix: pointed to wrong module

commit db77feb
Author: Stacey Gammon <gammon@elastic.co>
Date:   Thu Oct 18 14:20:09 2018 -0400

    Extend the timeout used to check if something exists. (elastic#24140)

commit a2172b9
Author: Maryia Lapata <mary.lopato@gmail.com>
Date:   Thu Oct 18 20:41:23 2018 +0300

    Fix structure of plural message (elastic#24208)

commit 4cc0103
Author: Catherine Liu <catherineqliu@outlook.com>
Date:   Thu Oct 18 13:03:57 2018 -0400

    Adds Canvas to Kibana Home (elastic#24038)

    * Adds Canvas to the feature registry

    * Removes timelion from the home page

commit 2b6cd21
Author: Justin Kambic <justin.kambic@elastic.co>
Date:   Thu Oct 18 12:43:52 2018 -0400

    [Logstash] [Pipeline Viewer] Improve LS monitoring accessibility (elastic#24169)

    * Update test data shape to conform to component proptypes.

    * Add aria-labels for pipeline viewer buttons.

commit 9f4ec18
Author: Brandon Kobel <brandon.kobel@gmail.com>
Date:   Thu Oct 18 09:30:42 2018 -0700

    Reporting cookies (elastic#24177)

    * Switching Reporting to use session cookies explicitly

    * Fixing bug when security is explicitly disabled

    * Responding to feedback

    * Fixing yarn.lock

commit 49168a9
Author: Brandon Kobel <brandon.kobel@gmail.com>
Date:   Thu Oct 18 09:28:18 2018 -0700

    Using ES list privileges API to determine the authorization mode  (elastic#24211)

    * Making it easier and more terse to specify the user for a test

    * Using ES list privileges API to determine the authorization mode

    This let's us correct use RBAC authorization for the proper users when
    security is enabled, and spaces is disabled to detect whether they have
    privileges of any kind and if so use RBAC.

    * Fixing authorization service test

    * Fixing tests referencing wrong expects

    * Putting create test back

    * Update x-pack/plugins/security/server/lib/authorization/mode.js

    * Update x-pack/plugins/security/server/lib/authorization/mode.js

commit 612bd74
Author: Matt Apperson <me@mattapperson.com>
Date:   Thu Oct 18 12:16:31 2018 -0400

    [BeatsCM] check for security after license, add support for standard license (elastic#24210)

commit 46d1a81
Author: Matt Apperson <me@mattapperson.com>
Date:   Thu Oct 18 12:16:01 2018 -0400

    merge RPM and DEB as they are the same command (elastic#24209)

commit 7d0eaed
Author: Gil Raphaelli <g@raphaelli.com>
Date:   Thu Oct 18 11:47:51 2018 -0400

    update apm-server start instructions for deb/rpm/windows (elastic#24104)

    * update apm-server start instructions for deb/rpm

    * update apm-server start instructions for windows

commit 2be837e
Author: Jake Landis <jake.landis@elastic.co>
Date:   Thu Oct 18 10:28:42 2018 -0500

    console: ingest node updates for auto-complete (elastic#24100)

    * add bytes processor
    * add dissect processor
    * add pipeline processor
    * add drop processor
    * add if conditional to each processor
    * add on_failure to each processor

commit 5441d74
Author: Felix Stürmer <weltenwort@users.noreply.github.com>
Date:   Thu Oct 18 17:00:08 2018 +0200

    Move mustache typings to devDependencies (elastic#24165)

    This moves the `@types/mustache` package from `dependencies` to `devDependencies` to avoid unnecessary inclusion in the build artifacts.

commit b4cbac6
Author: Tim Roes <mail@timroes.de>
Date:   Thu Oct 18 15:49:48 2018 +0200

    Fix memory leak in vislib on auto refresh (elastic#24134)

commit f382ee2
Author: Chris Roberson <chrisronline@gmail.com>
Date:   Thu Oct 18 09:05:27 2018 -0400

    Fixes from the demo (elastic#23922)

commit 8fc52b4
Author: Pete Harverson <peteharverson@users.noreply.github.com>
Date:   Thu Oct 18 13:34:44 2018 +0100

    [ML] Focus View Results link on Job wizards when job finishes (elastic#24190)

    * [ML] Focus View Results link on Job wizards when job finishes

    * [ML] Move function to set View Results link focus to new_job_utils

commit 9a3414c
Author: tibmt <pavelyukhnevich@yandex.ru>
Date:   Thu Oct 18 14:17:06 2018 +0300

    Translate heatmap and heatmap_options (elastic#23812)

    Translation of Heatmap visualization component

commit 58ba301
Author: tibmt <pavelyukhnevich@yandex.ru>
Date:   Thu Oct 18 13:58:57 2018 +0300

    Translate Area, Line, Horizontal and Vertical Bar (elastic#23823)

    Translation of Line, Area, Vertical and Horizontal Bar visualization components

commit c5d9583
Author: Pete Harverson <peteharverson@users.noreply.github.com>
Date:   Thu Oct 18 11:14:14 2018 +0100

    [ML] Lowers multi-bucket impact thresholds used for anomaly display (elastic#24136)

    * [ML] Lowers multi-bucket impact thresholds used for anomaly display

    * [ML] Adjust thresholds used in multi bucket impact unit tests
skh added a commit to skh/kibana that referenced this pull request Oct 22, 2018
@skh
Merge master.
41a3894 
Squashed commit of the following:

commit 7739410
Author: markharwood <markharwood@gmail.com>
Date:   Mon Oct 22 09:30:16 2018 +0100

    Graph fix: Remove “step” property which makes values other than 1, 1001, 2001 etc illegal (elastic#23610)

    Closes elastic#22054

commit 3ca2231
Author: markharwood <markharwood@gmail.com>
Date:   Mon Oct 22 09:27:17 2018 +0100

    Remove “step” property which makes values other than 1, 1001, 2001 etc illegal (elastic#23610)

    Closes elastic#22054

commit 98f7667
Author: Andrew Wilkins <axwalk@gmail.com>
Date:   Mon Oct 22 08:54:46 2018 +0800

    [APM] Update Go agent instructions (elastic#24111)

    - Update the Go agent instructions to refer to the new import path.
    - Change some of the wording to align with other agents.
    - Drop "beta" warning.

commit f6ba696
Author: Maryia Lapata <mary.lopato@gmail.com>
Date:   Sun Oct 21 15:39:15 2018 +0300

    Fix broken link on Watcher (elastic#24317)

commit 3fc8b35
Author: Josh Dover <me@joshdover.com>
Date:   Sat Oct 20 10:45:14 2018 -0500

    Add server OS information to telemetry stats (elastic#23793)

    * Add server OS data to monitoring collector and telemetry

    * Fixup naming

    * Fix functional tests

commit 9904bd9
Author: Spencer <email@spalger.com>
Date:   Fri Oct 19 20:29:38 2018 -0700

    [uiSettings] upgrade old config on read (elastic#24108)

    * doing config migration during config get if necessary

    * fixing issue with writing new config when user does not have write privilege

    * [uiSettings] only log about config upgrade on success

    * [uiSettings/createOrUpgradeSavedConfig] add onWriteError option

    * [uiSettings] return the upgradeAttributes if reader is unable to write upgrade

    * [uiSettings] update route tests to cover upgrade on get

    * [spaces/integration-tests] add config doc to expected objects

    * [uiSettings] avoid shadowed variable name

commit ab29946
Author: dave.snider@gmail.com <dave.snider@gmail.com>
Date:   Fri Oct 19 18:30:06 2018 -0700

    update eui to 4.5.1 (elastic#24218)

    * update eui to 4.5.1

    * icons declared for logging / infra

    * remove eui types that are now in EUI directly

    * clean up duplicated EUI typescript definitions

    * Fix EuiSelect usage in beats enrollment

commit 6b4b0fe
Author: Tyler Smalley <tylersmalley@me.com>
Date:   Fri Oct 19 17:15:29 2018 -0700

    Updates build file unit tests to be Windows Compatible (elastic#24296)

    POSTIX permissions are not available on windows and libuv reports only
    666 and 444 for if it's read or writeable.

    Additionally, on Windows and being reported on OSX, modifying directory
    timestamps in the same stream often does not work.

    Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

commit 8ee620d
Author: Tim Sullivan <tsullivan@users.noreply.github.com>
Date:   Fri Oct 19 15:44:23 2018 -0700

    Add note about automatic inclusion of all stats (elastic#24309)

commit 208bd51
Author: Spencer <email@spalger.com>
Date:   Fri Oct 19 15:28:12 2018 -0700

    [core/public/chrome] migrate controls, theme, and visibility apis (elastic#22987)

    * [core/public/chrome] migrate controls, theme, and visibility apis

    * [core/public] stop uiSettings service

    * [core/public/chrome] test that observables stop immedaiately after stop()

    * fix typos

    * [core/public/legacyPlatform] test globalNavState init

    * [ui/chrome] don't pass extra params

    * [core/public/chrome] test for dedupe-handling

    * [ui/chrome/theme] test with different values for logo and smallLogo

commit 2fa5ee5
Author: Josh Dover <me@joshdover.com>
Date:   Fri Oct 19 17:22:54 2018 -0500

    Add euiIconType for InfraOps and Logs links (elastic#24289)

commit 938d130
Author: Tyler Smalley <tylersmalley@me.com>
Date:   Fri Oct 19 15:10:27 2018 -0700

    Updates file unit tests to be Windows compatible (elastic#24281)

    Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

commit bd3f840
Author: Tim Sullivan <tsullivan@users.noreply.github.com>
Date:   Fri Oct 19 15:00:38 2018 -0700

    [docs/reporting] note about data table pdf (elastic#23921)

commit 9189c06
Author: Chris Cowan <chris@chriscowan.us>
Date:   Fri Oct 19 13:54:58 2018 -0700

    [Infra UI] Test for waffle map GraphQL endpoint (elastic#24184)

    * [Infra UI] Test for metrics GraphQL endpoint

    * Moving apollo-boost to devDeps

    * Converting tests to typescript

    * Renaming infraops to infra

    * Converting to typescript

    * renaming from infraops to infra

    * Adding waffle tests back in

commit 73d8bb9
Author: Peter Pisljar <peter.pisljar@gmail.com>
Date:   Fri Oct 19 20:40:05 2018 +0200

    always start with closed context menu (elastic#24252)

commit d8d2a18
Author: Nox911 <nox.911@gmail.com>
Date:   Fri Oct 19 21:02:58 2018 +0300

    Translations for Management -> Objects (elastic#23905)

    * fix tests and update snapshots

    * fix id names

    * fix test and update snapshots

    * Update unit test snapshots

    * fix issues

    * Update snapshots

    * Fix issues

commit 371eca2
Author: Nox911 <nox.911@gmail.com>
Date:   Fri Oct 19 20:56:50 2018 +0300

    Translations for Advanced Settings (elastic#23881)

    * translate kbn.management.advanced_settings

    * fix tests and update snapshots

    * fix tests

    * fix  issues

    * fix id in get_category-name.js

    * Update unit test snapshot

    * update snapshot

    * Fix issues

commit a5c28d5
Author: Nox911 <nox.911@gmail.com>
Date:   Fri Oct 19 20:49:37 2018 +0300

    Feature/translate watcher(part_3) (elastic#24066)

    * translate watcher(part_3)

    * fix default message in monitoring_watch.js

    * fix issues

    * fix issues

    * fix issues

    * fix issues

commit fa95143
Author: Nox911 <nox.911@gmail.com>
Date:   Fri Oct 19 20:48:31 2018 +0300

    Feature/translate watcher(part_2) (elastic#24017)

    * translate watcher(pad_2)

    * fix issues

    * fix issues

commit 6247189
Author: Nox911 <nox.911@gmail.com>
Date:   Fri Oct 19 20:47:05 2018 +0300

    Feature/translate watcher(part_1) (elastic#23989)

    * translate watcher(pad_1)

    * fix test

    * fix issues

    * fix the same id name

    * fix default message

    * fix issues

commit 3c15067
Author: Chris Cowan <chris@chriscowan.us>
Date:   Fri Oct 19 10:39:21 2018 -0700

    [Infra UI] Test for metrics GraphQL endpoint (elastic#24179)

    * [Infra UI] Test for metrics GraphQL endpoint

    * Moving apollo-boost to devDeps

    * Converting tests to typescript

    * Renaming infraops to infra

commit c5e61c3
Author: Stacey Gammon <gammon@elastic.co>
Date:   Fri Oct 19 13:21:12 2018 -0400

    EAH - Typescript state_monitor_factory (elastic#23945)

    * Typescript state_monitor_factory

    * Fix linter error with possibly undefined

    * Expand typings to include hash stuff and expand the State type definition more.

    * Mark readonly

commit cc75547
Author: tibmt <pavelyukhnevich@yandex.ru>
Date:   Fri Oct 19 18:25:55 2018 +0300

    Translate Gauge and Goal (elastic#23882)

    * Translate Gauge and Goal

    * fix some names, rewrite some code and add 'kbnVislibVisTypes' to '.i18nrc.json'

    * add 'Required' translation

    * fix 'requiredText' bug

    * use \' instead of &quot;

    * update heatmap component

    * Update gauge.js

    * Update gauge.js

    * Update gauge.js

commit 4b9e13c
Author: Maryia Lapata <mary.lopato@gmail.com>
Date:   Fri Oct 19 17:59:07 2018 +0300

    Init I18n before Notifications start (elastic#23902)

    * Init I18n before Notifications start

    * Remove i18n initialization in AngularJS since it will be already initialized in CoreSystem

    * Remove unused translationsApi

    * Remove redundant i18n.init invocation

    * Remove i18n tests since  i18n.init was removed and input params for AppBootstrap were changed

    * Move i18n initialization to the entry file.

commit 03d14a7
Author: Bill McConaghy <bill.mcconaghy@elastic.co>
Date:   Fri Oct 19 10:48:41 2018 -0400

    fixing mangling of floating point numbers by console (elastic#23685)

    * fixing mangling of floating point numbers by console

    * fixing tests

    * fixing issue with large requests

    * restoring old code for server side as it handles large responses better

commit a23124e
Author: Matt Apperson <me@mattapperson.com>
Date:   Fri Oct 19 10:17:45 2018 -0400

    [BeatsCM] Fixes and issue where if security is disabled, BeatsCM breaks Kibana (elastic#24249)

    * fix spelling

    * fix license and security checks

    * removed unused vars

    * cleanup

    * remove security check from route def as it is already managed in-route

commit da26fcb
Author: Melissa Alvarez <melissa.alvarez@elastic.co>
Date:   Fri Oct 19 09:42:21 2018 +0100

    [ML] Ensure applying/removing groups menu is keyboard accessible (elastic#24212)

    * add group list arrow nav

    * up/down moved into own functions

    * always prevent default on arrow key press

commit db905c0
Author: dave.snider@gmail.com <dave.snider@gmail.com>
Date:   Thu Oct 18 18:12:39 2018 -0700

    remove eui css import from beats/infra (elastic#24245)

commit 314d1c4
Author: Lukas Olson <olson.lukas@gmail.com>
Date:   Thu Oct 18 13:37:44 2018 -0700

    Canvas function/argument/value autocomplete (elastic#23200)

    * feat: canvas autocomplete

    * fix: remove unused files

    * autocomplete ui cleanup

    * fix: handle stuff inside quotes

    * fix: canvas suggestion comparator

    * fix: spaces at the beginning of expressions

    * fix: move header out of autocomplete component itself

    * fix: add tests

    * fix: failing test

    * fix: pointed to wrong module

commit db77feb
Author: Stacey Gammon <gammon@elastic.co>
Date:   Thu Oct 18 14:20:09 2018 -0400

    Extend the timeout used to check if something exists. (elastic#24140)

commit a2172b9
Author: Maryia Lapata <mary.lopato@gmail.com>
Date:   Thu Oct 18 20:41:23 2018 +0300

    Fix structure of plural message (elastic#24208)

commit 4cc0103
Author: Catherine Liu <catherineqliu@outlook.com>
Date:   Thu Oct 18 13:03:57 2018 -0400

    Adds Canvas to Kibana Home (elastic#24038)

    * Adds Canvas to the feature registry

    * Removes timelion from the home page

commit 2b6cd21
Author: Justin Kambic <justin.kambic@elastic.co>
Date:   Thu Oct 18 12:43:52 2018 -0400

    [Logstash] [Pipeline Viewer] Improve LS monitoring accessibility (elastic#24169)

    * Update test data shape to conform to component proptypes.

    * Add aria-labels for pipeline viewer buttons.

commit 9f4ec18
Author: Brandon Kobel <brandon.kobel@gmail.com>
Date:   Thu Oct 18 09:30:42 2018 -0700

    Reporting cookies (elastic#24177)

    * Switching Reporting to use session cookies explicitly

    * Fixing bug when security is explicitly disabled

    * Responding to feedback

    * Fixing yarn.lock

commit 49168a9
Author: Brandon Kobel <brandon.kobel@gmail.com>
Date:   Thu Oct 18 09:28:18 2018 -0700

    Using ES list privileges API to determine the authorization mode  (elastic#24211)

    * Making it easier and more terse to specify the user for a test

    * Using ES list privileges API to determine the authorization mode

    This let's us correct use RBAC authorization for the proper users when
    security is enabled, and spaces is disabled to detect whether they have
    privileges of any kind and if so use RBAC.

    * Fixing authorization service test

    * Fixing tests referencing wrong expects

    * Putting create test back

    * Update x-pack/plugins/security/server/lib/authorization/mode.js

    * Update x-pack/plugins/security/server/lib/authorization/mode.js

commit 612bd74
Author: Matt Apperson <me@mattapperson.com>
Date:   Thu Oct 18 12:16:31 2018 -0400

    [BeatsCM] check for security after license, add support for standard license (elastic#24210)

commit 46d1a81
Author: Matt Apperson <me@mattapperson.com>
Date:   Thu Oct 18 12:16:01 2018 -0400

    merge RPM and DEB as they are the same command (elastic#24209)

commit 7d0eaed
Author: Gil Raphaelli <g@raphaelli.com>
Date:   Thu Oct 18 11:47:51 2018 -0400

    update apm-server start instructions for deb/rpm/windows (elastic#24104)

    * update apm-server start instructions for deb/rpm

    * update apm-server start instructions for windows

commit 2be837e
Author: Jake Landis <jake.landis@elastic.co>
Date:   Thu Oct 18 10:28:42 2018 -0500

    console: ingest node updates for auto-complete (elastic#24100)

    * add bytes processor
    * add dissect processor
    * add pipeline processor
    * add drop processor
    * add if conditional to each processor
    * add on_failure to each processor

commit 5441d74
Author: Felix Stürmer <weltenwort@users.noreply.github.com>
Date:   Thu Oct 18 17:00:08 2018 +0200

    Move mustache typings to devDependencies (elastic#24165)

    This moves the `@types/mustache` package from `dependencies` to `devDependencies` to avoid unnecessary inclusion in the build artifacts.

commit b4cbac6
Author: Tim Roes <mail@timroes.de>
Date:   Thu Oct 18 15:49:48 2018 +0200

    Fix memory leak in vislib on auto refresh (elastic#24134)

commit f382ee2
Author: Chris Roberson <chrisronline@gmail.com>
Date:   Thu Oct 18 09:05:27 2018 -0400

    Fixes from the demo (elastic#23922)

commit 8fc52b4
Author: Pete Harverson <peteharverson@users.noreply.github.com>
Date:   Thu Oct 18 13:34:44 2018 +0100

    [ML] Focus View Results link on Job wizards when job finishes (elastic#24190)

    * [ML] Focus View Results link on Job wizards when job finishes

    * [ML] Move function to set View Results link focus to new_job_utils

commit 9a3414c
Author: tibmt <pavelyukhnevich@yandex.ru>
Date:   Thu Oct 18 14:17:06 2018 +0300

    Translate heatmap and heatmap_options (elastic#23812)

    Translation of Heatmap visualization component

commit 58ba301
Author: tibmt <pavelyukhnevich@yandex.ru>
Date:   Thu Oct 18 13:58:57 2018 +0300

    Translate Area, Line, Horizontal and Vertical Bar (elastic#23823)

    Translation of Line, Area, Vertical and Horizontal Bar visualization components

commit c5d9583
Author: Pete Harverson <peteharverson@users.noreply.github.com>
Date:   Thu Oct 18 11:14:14 2018 +0100

    [ML] Lowers multi-bucket impact thresholds used for anomaly display (elastic#24136)

    * [ML] Lowers multi-bucket impact thresholds used for anomaly display

    * [ML] Adjust thresholds used in multi bucket impact unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

@AlonaNadler AlonaNadler Awaiting requested review from AlonaNadler

Assignees
No one assigned
Labels
Project:Accessibility Team:Logstash Team:Monitoring Stack Monitoring team v6.5.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@justinkambic @elasticmachine @snide