Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [New Platform] Validate config upfront (#35453) #36439

Merged
merged 1 commit into from
May 10, 2019

Commits on May 10, 2019

  1. [New Platform] Validate config upfront (elastic#35453)

    * Introduce new convention for config definition.
    
    We need to define a way to acquire configuration schema as a part of
    plugin definition. Having schema we can split steps of
    config validation and plugin instantiation.
    
    * Discover plugins, read their schema and validate the config.
    
    Config validation finished before core services and plugins read from it.
    That allows us to fail fast and have predictable validation results.
    
    * Instantiate plugins using DiscoveredPluginsDefinitions.
    
    * Update tests for new API.
    
    * test server is not created if config validation fails
    
    * move plugin discovery to plugin service pre-setup stage.
    
    Set validation schemes in ConfigService.preSetup stage.
    
    * fix eslint problem
    
    * generate docs
    
    * address Rudolfs comments
    
    * separate core services and plugins validation
    
    * rename files for consistency
    
    * address comments for root.js
    
    * address comments #1
    
    * useSchema everywhere for consistency. get rid of validateAll
    
    * plugin system runs plugin config validation
    
    * rename configDefinition
    
    * move plugin schema registration in plugins plugins service
    
    plugins system is not setup when kibana is run in optimizer mode,
    so config keys aren't marked as applied.
    
    * cleanup
    
    * update docs
    
    * address comments
    mshustov committed May 10, 2019
    Configuration menu
    Copy the full SHA
    3f5481a View commit details
    Browse the repository at this point in the history