Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup integration test #36766

Merged
merged 1 commit into from
May 21, 2019

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented May 21, 2019

Summary

Closes #36256
after #35297 we can use setup/start contracts in tests and don't need to declare a separate plugin for this

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mshustov mshustov added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc chore labels May 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@mshustov mshustov marked this pull request as ready for review May 21, 2019 14:03
@mshustov mshustov requested a review from a team as a code owner May 21, 2019 14:03
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are much clearer now

@mshustov mshustov merged commit ef38c4d into elastic:master May 21, 2019
@mshustov mshustov deleted the http-intergration-test-cleanup branch May 21, 2019 15:35
mshustov added a commit to mshustov/kibana that referenced this pull request May 21, 2019
mshustov added a commit that referenced this pull request May 22, 2019
@mshustov mshustov added the release_note:skip Skip the PR/issue when compiling release notes label May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup http server integration tests
3 participants