Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify response interface in handler and request interceptors #42442

Merged
merged 17 commits into from Aug 8, 2019
Merged

Unify response interface in handler and request interceptors #42442

merged 17 commits into from Aug 8, 2019

Commits on Aug 1, 2019

  1. add response factory to the interceptors

    @mshustov
    mshustov committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    2ee1d57 View commit details
    Browse the repository at this point in the history

  2. adopt x-pack code to the changes

    @mshustov
    mshustov committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    6f6779a View commit details
    Browse the repository at this point in the history

  3. Add a separate response factory for lifecycles. 

    Only route handler can respond with 2xx response.
Interceptors may redirect or reject an incoming request.
    @mshustov
    mshustov committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    4c434d6 View commit details
    Browse the repository at this point in the history

  4. re-generate docs

    @mshustov
    mshustov committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    4af2986 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. response.internal --> response.internalError

    @mshustov
    mshustov committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    534ad91 View commit details
    Browse the repository at this point in the history

  2. use internalError for exceptions in authenticator

    @mshustov
    mshustov committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    6fb0fec View commit details
    Browse the repository at this point in the history

  3. before Security plugin proxied ES error status code. now sets explici… 

    …tly.
    @mshustov
    mshustov committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    efe4dae View commit details
    Browse the repository at this point in the history

  4. provide error via message field of error response for BWC

    @mshustov
    mshustov committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    fba3b7a View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Merge branch 'master' into issue-41996-response-factory-to-interceptors

    @mshustov
    mshustov committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    6d4f6f7 View commit details
    Browse the repository at this point in the history

  2. update docs

    @mshustov
    mshustov committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    5eadb6e View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. add customError response

    @mshustov
    mshustov committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    9342185 View commit details
    Browse the repository at this point in the history

  2. restore integration test and update unit tests

    @mshustov
    mshustov committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    8634bea View commit details
    Browse the repository at this point in the history

  3. update docs

    @mshustov
    mshustov committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    717d242 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into issue-41996-response-factory-to-interceptors

    @mshustov
    mshustov committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    a1c204c View commit details
    Browse the repository at this point in the history

  5. support Hapi error format for BWC

    @mshustov
    mshustov committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    33e46e9 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. add a couple of tests

    @mshustov
    mshustov committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    89c80c2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into issue-41996-response-factory-to-interceptors

    @mshustov
    mshustov committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    7383d7d View commit details
    Browse the repository at this point in the history