[SIEM] Add timeline id in url + refactor code #43943

XavierM · 2019-08-25T13:55:32Z

Summary

Add Timeline Id in url
Only keep in url object who are relevant to the page
Refactor component to only update redux store at global initialization
Fix unit testing, old's @XavierM messed up everything here ( I am ashamed of it but it happened) but new's @XavierM realizes his mistakes and fix it.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
~~[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~[ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~[ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~[ ] This was checked for breaking API changes and was labeled appropriately~~
~~[ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

elasticmachine · 2019-08-25T13:55:34Z

Pinging @elastic/siem

elasticmachine · 2019-08-25T15:08:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

x-pack/legacy/plugins/siem/public/components/url_state/index_mocked.test.tsx

angorayc

Thanks @XavierM, nicely done! I like the changes, it really makes the flow easier to follow!
Some minor things found but happy to ship it as so and do them as bug fixing:

The queryLocation on link address you just copy doesn't match to what it suppose to be
Steps for reproduce:

Go to Hosts page
Choose a host name and click on filter for value
Right click on Network tab and click copu link address

Kqlbar is not refreshing after user input:
steps to reproduce:

XavierM · 2019-08-26T19:05:22Z

Thanks @XavierM, nicely done! I like the changes, it really makes the flow easier to follow!
Some minor things found but happy to ship it as so and do them as bug fixing:

The queryLocation on link address you just copy doesn't match to what it suppose to be
Steps for reproduce:

Go to Hosts page

Choose a host name and click on filter for value

Right click on Network tab and click copu link address

Kqlbar is not refreshing after user input:
steps to reproduce:

Click on http://localhost:5601/app/siem#/hosts/?kqlQuery=(filterQuery:(expression:'host.name:%20%22beats-ci-immutable-centos-7-1566828754401694040%22',kind:kuery),queryLocation:hosts.page)&timelineId=c8bec320-a7f2-11e9-8950-0f78dfe8d3c9&timerange=(global:(linkTo:!(),timerange:(from:1566829069303,kind:absolute,to:1566829957589)),timeline:(linkTo:!(),timerange:(from:1563304238802,kind:absolute,to:1563305138803)))

Update kqlbar and hit refresh

The url remains the same

Yes, it is making sense. I will work on it right now to improve that

elasticmachine · 2019-08-26T19:22:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

stephmilovic · 2019-08-26T19:53:08Z

old's @XavierM messed up everything here ( I am ashamed of it but it happened) but new's @XavierM realizes his mistakes and fix it.
🤣

stephmilovic · 2019-08-26T20:26:22Z

I'm seeing this console warning on page load:

Warning: Failed prop type: Invalid prop `component` of type `object` supplied to `Route`, expected `function`.

stephmilovic

Something is wrong with the timeline/global lock. When I visit this url: /app/siem#/network?timerange=(global:(linkTo:!(timeline),timerange:(from:1564689809186,kind:absolute,to:1564691609186)),timeline:(linkTo:!(global),timerange:(from:1564689809186,kind:absolute,to:1564691609186))) it gets changed to this on pageload: /app/siem#/network?timerange=(global:(linkTo:!(),timerange:(from:1564689809186,kind:absolute,to:1564691609186)),timeline:(linkTo:!(timeline),timerange:(from:1564689809186,kind:absolute,to:1564691609186)))

stephmilovic · 2019-08-26T20:15:39Z

x-pack/legacy/plugins/siem/public/components/url_state/helpers.test.ts

-      queryLocation: CONSTANTS.hostsDetails,
-      type: hostsModel.HostsType.details,
-    });
+    const result = isKqlForRoute('/hosts', CONSTANTS.hostsDetails);


elasticmachine · 2019-08-26T23:41:55Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-27T15:21:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-27T22:36:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

XavierM · 2019-08-27T23:46:27Z

@stephmilovic These Cypress tests were great, I now feel comfortable with this PR. Thanks a lot for working hard on these tests. (so Useful!!!) 🍸 🎈

elasticmachine · 2019-08-28T01:12:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

XavierM · 2019-08-28T14:36:32Z

I'm seeing this console warning on page load:

Warning: Failed prop type: Invalid prop `component` of type `object` supplied to `Route`, expected `function`.

This was a fun one to figure it out, the problem was that I changed the HomePage component to be a memo but the props from Route component only accept pure function. Therefore, we will need to update our react-route-dom library to let Route accept memo components.
I decide to put it back as a pure function, I do not think we should upgrade the library just before FF.

remix-run/react-router#6471

stephmilovic

AMAZING work here @XavierM. Great cleanups, and so happy to see those cypress tests running smoothly. Gives me great confidence in our work! LGTM 🚀

angorayc · 2019-08-28T16:00:18Z

Awesome! I played around with it and it works as expected. Thanks for fixing it,
I am happy to ship it 🚢 🚢 🚢

spalger · 2019-08-28T18:54:26Z

retest

elasticmachine · 2019-08-28T20:28:32Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-29T03:29:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

XavierM · 2019-08-29T03:42:59Z

x-pack/legacy/plugins/siem/public/components/open_timeline/helpers.ts

-      savedObjectId: duplicate ? null : timelineModel.savedObjectId,
-      version: duplicate ? null : timelineModel.version,
-      title: duplicate ? '' : timelineModel.title || '',
-    } as TimelineModel,


no more AS

elasticmachine · 2019-08-29T04:10:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-29T05:52:57Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-29T10:22:51Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

… at global initialization

…line because of nasty type loop

elasticmachine · 2019-08-29T14:22:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Add timelineId in URL + refactor url_state to only update redux store at global initialization * add/fix unit test * remove async * wip * new tests for timeline url state * fix tests * rm unused * Add the expected href around global tab * fix conflict * fix console error about Route * fix type + test -- needed to refactor to default the value of the timline because of nasty type loop * add href on detail tab to match

XavierM added review Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Aug 25, 2019

XavierM self-assigned this Aug 25, 2019

XavierM commented Aug 26, 2019

View reviewed changes

x-pack/legacy/plugins/siem/public/components/url_state/index_mocked.test.tsx Outdated Show resolved Hide resolved

XavierM force-pushed the siem-url-timeline-id branch from 8d96dd3 to 078a685 Compare August 26, 2019 17:32

XavierM changed the title ~~Add timeline id in url + refactor code~~ [SIEM] Add timeline id in url + refactor code Aug 26, 2019

angorayc approved these changes Aug 26, 2019

View reviewed changes

stephmilovic reviewed Aug 26, 2019

View reviewed changes

XavierM force-pushed the siem-url-timeline-id branch from 5a24a59 to 9490783 Compare August 27, 2019 23:49

XavierM force-pushed the siem-url-timeline-id branch from 9490783 to 57f07b3 Compare August 28, 2019 14:49

stephmilovic approved these changes Aug 28, 2019

View reviewed changes

XavierM force-pushed the siem-url-timeline-id branch from 57f07b3 to 673a077 Compare August 29, 2019 03:23

XavierM commented Aug 29, 2019

View reviewed changes

XavierM and others added 12 commits August 29, 2019 06:49

Add timelineId in URL + refactor url_state to only update redux store…

b7ef982

… at global initialization

add/fix unit test

2ba758f

remove async

dda0ab5

wip

7510aeb

new tests for timeline url state

81db500

fix tests

a48f68f

rm unused

92de577

Add the expected href around global tab

6304455

fix conflict

6b9f3f4

fix console error about Route

237a7bc

fix type + test -- needed to refactor to default the value of the tim…

8aad270

…line because of nasty type loop

add href on detail tab to match

d2d5da1

XavierM force-pushed the siem-url-timeline-id branch from 6fcfb66 to d2d5da1 Compare August 29, 2019 12:42

tsg merged commit 0be4cf9 into elastic:master Aug 29, 2019

XavierM mentioned this pull request Aug 29, 2019

[7.4] [SIEM] Add timeline id in url + refactor code (#43943) #44445

Merged

XavierM mentioned this pull request Aug 30, 2019

[7.x] [SIEM] Add timeline id in url + refactor code (#43943) #44448

Merged

XavierM deleted the siem-url-timeline-id branch June 4, 2020 16:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM] Add timeline id in url + refactor code #43943

[SIEM] Add timeline id in url + refactor code #43943

XavierM commented Aug 25, 2019 •

edited

elasticmachine commented Aug 25, 2019

elasticmachine commented Aug 25, 2019

angorayc left a comment •

edited

XavierM commented Aug 26, 2019

elasticmachine commented Aug 26, 2019

stephmilovic commented Aug 26, 2019

stephmilovic commented Aug 26, 2019

stephmilovic left a comment

stephmilovic Aug 26, 2019

elasticmachine commented Aug 26, 2019

elasticmachine commented Aug 27, 2019

elasticmachine commented Aug 27, 2019

XavierM commented Aug 27, 2019

elasticmachine commented Aug 28, 2019

XavierM commented Aug 28, 2019 •

edited

stephmilovic left a comment

angorayc commented Aug 28, 2019

spalger commented Aug 28, 2019

elasticmachine commented Aug 28, 2019

elasticmachine commented Aug 29, 2019

XavierM Aug 29, 2019

elasticmachine commented Aug 29, 2019

elasticmachine commented Aug 29, 2019

elasticmachine commented Aug 29, 2019

elasticmachine commented Aug 29, 2019

[SIEM] Add timeline id in url + refactor code #43943

[SIEM] Add timeline id in url + refactor code #43943

Conversation

XavierM commented Aug 25, 2019 • edited

Summary

Checklist

For maintainers

elasticmachine commented Aug 25, 2019

elasticmachine commented Aug 25, 2019

💚 Build Succeeded

angorayc left a comment • edited

Choose a reason for hiding this comment

XavierM commented Aug 26, 2019

elasticmachine commented Aug 26, 2019

💚 Build Succeeded

stephmilovic commented Aug 26, 2019

stephmilovic commented Aug 26, 2019

stephmilovic left a comment

Choose a reason for hiding this comment

stephmilovic Aug 26, 2019

Choose a reason for hiding this comment

elasticmachine commented Aug 26, 2019

💔 Build Failed

elasticmachine commented Aug 27, 2019

💔 Build Failed

elasticmachine commented Aug 27, 2019

💚 Build Succeeded

XavierM commented Aug 27, 2019

elasticmachine commented Aug 28, 2019

💔 Build Failed

XavierM commented Aug 28, 2019 • edited

stephmilovic left a comment

Choose a reason for hiding this comment

angorayc commented Aug 28, 2019

spalger commented Aug 28, 2019

elasticmachine commented Aug 28, 2019

💔 Build Failed

elasticmachine commented Aug 29, 2019

💚 Build Succeeded

XavierM Aug 29, 2019

Choose a reason for hiding this comment

elasticmachine commented Aug 29, 2019

💚 Build Succeeded

elasticmachine commented Aug 29, 2019

💔 Build Failed

elasticmachine commented Aug 29, 2019

💚 Build Succeeded

elasticmachine commented Aug 29, 2019

💚 Build Succeeded

XavierM commented Aug 25, 2019 •

edited

angorayc left a comment •

edited

XavierM commented Aug 28, 2019 •

edited