Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps Jest related packages #78720

Merged
merged 6 commits into from
Oct 1, 2020
Merged

Bumps Jest related packages #78720

merged 6 commits into from
Oct 1, 2020

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Sep 29, 2020 •
edited

Upgrades Jest to 26.4.2 and related packages.

Was blocked by #75357
Blocks #77894

Changelogs:

@tylersmalley tylersmalley mentioned this pull request Sep 29, 2020
Merged
8 tasks
@tylersmalley tylersmalley force-pushed the jest-26-4-2 branch 3 times, most recently from 4359cd0 to 8110746 Compare September 30, 2020 04:45
Bumps Jest related packages
c2cc008 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley marked this pull request as ready for review September 30, 2020 14:04
@tylersmalley tylersmalley requested review from a team as code owners September 30, 2020 14:04
@tylersmalley tylersmalley requested a review from a team September 30, 2020 14:04
@tylersmalley tylersmalley requested review from a team as code owners September 30, 2020 14:04
@tylersmalley tylersmalley requested a review from a team September 30, 2020 14:04
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.0 v8.0.0 labels Sep 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

patrykkopycinski
patrykkopycinski approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM/Endpoint changes LGTM!

Tyler Smalley added 3 commits September 30, 2020 15:32
Updates
1116cef 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Remove unused import
f0ba430 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Prefer async tests
8fa784f 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Prefer async tests
56fa166 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
mikecote
mikecote approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting team related code LGTM once @pmuellr confirms this question #78720 (comment).

mshustov
mshustov approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for the platform changes

peteharverson
peteharverson approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML and Transform plugin changes LGTM

chrisronline
chrisronline approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for stack monitoring.

alisonelizabeth
alisonelizabeth approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES-UI changes LGTM

poffdeluxe
poffdeluxe approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas changes lgtm

pmuellr
pmuellr approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change in event_log LGTM

x-pack/plugins/event_log/server/lib/ready_signal.test.ts Show resolved Hide resolved
spalger
spalger approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylersmalley
Copy link
Contributor Author

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor Author

tylersmalley commented Oct 1, 2020 •
edited

@elastic/endpoint-app-team & @elastic/kibana-app - Still awaiting reviewing from you all - however, considering these are minor changes only affect tests, I will move forward merging as soon as the recent CI completes. I am happy to address any feedback when you do get around to reviewing.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
monitoring 1.2MB 1.2MB -48.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley merged commit 7211f78 into elastic:master Oct 1, 2020
@tylersmalley tylersmalley mentioned this pull request Oct 1, 2020
Closed
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Oct 1, 2020
Bumps Jest related packages (elastic#78720)
c2aed68 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	x-pack/plugins/transform/public/app/hooks/use_index_data.test.tsx
#	yarn.lock
@tylersmalley tylersmalley mentioned this pull request Oct 5, 2020
Merged
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Oct 5, 2020
Bumps Jest related packages (elastic#78720)
a8b18d8 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	packages/kbn-optimizer/package.json
#	yarn.lock
tylersmalley pushed a commit that referenced this pull request Oct 5, 2020
[7.x] Bumps Jest related packages (#78720) (#79524)
ff54de0 
* Bumps Jest related packages (#78720)

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
# Conflicts:
#	packages/kbn-optimizer/package.json
#	yarn.lock

* Updates kbn-pm dist

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@chrisronline chrisronline chrisronline approved these changes

@mattkime mattkime mattkime approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@spalger spalger spalger approved these changes

@mshustov mshustov mshustov approved these changes

@mikecote mikecote mikecote approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet