[Reporting/Build Chromium] Add a developer script to find the Chromium commit #94033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
force-pushed
the
spacetime/build-chromium
branch
from
218093c
to
da7110e
Compare
tsullivan
added
Feature:Build Tooling
v7.13.0
v8.0.0
Feature:Reporting
spalger
reviewed
Mar 9, 2021
spalger
reviewed
Mar 9, 2021
tylersmalley
reviewed
Mar 9, 2021
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
tsullivan
added
the
release_note:skip
spalger
reviewed
Mar 10, 2021
src/dev/chromium_version.ts
Outdated
| } | ||
| }, | ||
| { | ||
| description: dedent(chalk` |
There was a problem hiding this comment.
nit: we already pass the description to dedent
spalger
approved these changes
Mar 10, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
streamich
approved these changes
Mar 10, 2021
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Mar 10, 2021
…m commit (elastic#94033) * script that finds the chromium commit * use run from dev-utils * update docs and inch towards build pipeline * more docs updates * move the scripts the root * review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it easier for non-experts to build new versions of Chromium for Kibana Reporting, that is compatible with the release of the Puppeteer node module used in Kibana.
Example: find the Chromium commit has that is currently used for Kibana Reporting
Example: find the Chromium commit we need to build if we want to use Puppeteer v5.5.0:
As a way to verify the revision info that is actually installed in Kibana, this PR adds debug logs to the runtime while executing a screenshot report: