Update plugins-metadata.json with integration-snmp: set skiplist to false #16137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenzone
commented
May 3, 2024
| @@ -433,6 +433,10 @@ | |||
| "default-plugins": true, | |||
| "skip-list": false | |||
| }, | |||
| "logstash-integration-snmp": { | |||
| "default-plugins": false, | |||
There was a problem hiding this comment.
Note that I'm setting default -> false for now
|
💚 Build Succeeded
cc @karenzone |
Once we flip the integration to become the default, we should make the individual plugins non default and add them to the skip list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
integration-snmpto plugins-metadata.json so that it will be picked up for the Logstash Reference plugin docgenWhy?
After the VPR job ran and picked up
integration-snmp, I kicked off a docgen for Logstash Reference onmain. It didn't pick anything up, and I believe that's because we need this piece added to plugins-metadata.json.Aligning Logstash Reference (LSR) docgen settings
@jsvd, what changes should I make to
input-snmpandinput-snmp-trapsettings in https://github.com/elastic/logstash/blame/main/rakelib/plugins-metadata.json?At 8.15 I believe that we'll want to set the individual plugins to
"skip-list": true. Is the current config acceptable in the interim?