Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY up ES connection #209

Merged
merged 10 commits into from
Nov 27, 2022
Merged

DRY up ES connection #209

merged 10 commits into from
Nov 27, 2022

Conversation

webfella
Copy link

@webfella webfella commented Nov 23, 2022 •
edited

First part of #203.

@webfella webfella force-pushed the dry-up-es-connection-and-client branch from d01159e to 8c70e02 Compare November 23, 2022 05:14
webfella
webfella commented Nov 23, 2022
View reviewed changes
Copy link
Author

@webfella webfella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be back on later with fresh eyes, but I've captured what I'm stuck on at the moment @tobio if you have any insight.

internal/schema/connection.go Outdated Show resolved Hide resolved
@webfella webfella self-assigned this Nov 23, 2022
tobio
tobio reviewed Nov 23, 2022
View reviewed changes
internal/schema/connection.go Outdated Show resolved Hide resolved
internal/schema/connection.go Outdated Show resolved Hide resolved
internal/schema/connection.go Outdated Show resolved Hide resolved
internal/utils/utils.go Outdated Show resolved Hide resolved
provider/provider.go Outdated Show resolved Hide resolved
@webfella webfella marked this pull request as ready for review November 23, 2022 23:40
@webfella webfella changed the title DRY up ES connection and client DRY up ES connection Nov 24, 2022
@webfella webfella requested a review from tobio November 25, 2022 01:14
tobio
tobio approved these changes Nov 27, 2022
View reviewed changes
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webfella webfella merged commit 08035ee into elastic:main Nov 27, 2022
@webfella webfella deleted the dry-up-es-connection-and-client branch November 27, 2022 23:20
@Kushmaro
Copy link
Contributor

Kushmaro commented Dec 5, 2022 •
edited

Waiting on details about this one, mainly we just need to make sure such use case example like the guide below remains intact

https://registry.terraform.io/providers/elastic/elasticstack/latest/docs/guides/elasticstack-and-cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobio tobio tobio approved these changes

Assignees

@webfella webfella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@webfella @Kushmaro @tobio