Fix non-breaking vulnerabilities #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran npm audit fix and most of the vulnerabilities have been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are still
10 vulnerabilities (3 moderate, 7 high).We need to allocate more time to carefully investigate what is causing the breaking changes when we "fix" those other 10 vulnerabilities. With the initial release of 1.0.3, there was no traceability to see what changes could've caused the failure.
Findings for what's causing the initial breakage for traceability:
All the remaining vulnerabilities are coming from
textlint-scriptbeing upgraded to 12.1.1. However, once we do so, it causes an error:ReferenceError: fs is not defined.