fix(dmg): Escaping special characters in DMG entries (#5987)

electron-userland · Jun 26, 2021 · c368f62 · c368f62
1 parent 86a538b
commit c368f62
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/dmg-builder/src/dmg.ts b/packages/dmg-builder/src/dmg.ts
@@ -314,10 +314,11 @@ async function computeDmgEntries(specification: DmgOptions, volumePath: string,
 
     const entryPath = c.path || `${packager.appInfo.productFilename}.app`
     const entryName = c.name || path.basename(entryPath)
+    const escapedEntryName = entryName.replace(/['\\]/g, match => `\\${match}`)
     if (result.length !== 0) {
       result += ",\n"
     }
-    result += `'${entryName}': (${c.x}, ${c.y})`
+    result += `'${escapedEntryName}': (${c.x}, ${c.y})`
 
     if (c.type === "link") {
       asyncTaskManager.addTask(exec("ln", ["-s", `/${entryPath.startsWith("/") ? entryPath.substring(1) : entryPath}`, `${volumePath}/${entryName}`]))