feat(electron-updater): allow custom update providers (#3656) #5984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it possible to use custom publishers with electron-updater; the caller is required to create a custom options to the updater that passes in the constructor function for a class that implments Provider<any>. Fixes electron-userland#3656.
mmaietta
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the custom publisher can't be used in combination with
electron-updater: there is a hard-coded list of update providers, and an exception is thrown if the publisher isn't one of the known ones.This adds the ability to use a custom provider; however, the caller must pass in a custom
optionsobject where one of the fields contains a constructor function.This doesn't seem to affect the tests (that is, they still pass fine).