Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping special characters in DMG entries #5987

Merged
merged 2 commits into from Jun 26, 2021

Conversation

pedro-pedrosa
Copy link
Contributor

@pedro-pedrosa pedro-pedrosa commented Jun 25, 2021

Fixes an issue when the productName contains apostrophes. this is needed because in the python script it creates a literal string but the string is not escaped so an apostrophe terminates the string.

I have also added the backslash to the regex for completeness sake even though I don't think it's needed because it's sanitized out.

@mmaietta mmaietta merged commit c368f62 into electron-userland:master Jun 26, 2021
@mmaietta
Copy link
Collaborator

Thanks for your contribution!

@pedro-pedrosa pedro-pedrosa deleted the escape-dmg-entries branch June 26, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants