misc: enable windows ci node #5695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 9, 2021 14:06
…to run Adjusting folder structure to be aligned with TEST_FILES regex used per each CI node for optimal speed/distribution Deactivated various windows tests that were broken, they were never running anyways, so no harm done considering the rest of the test suite can run
# Conflicts: # packages/app-builder-lib/src/codeSign/windowsCodeSign.ts
|
Thank you. We do use several CI providers to spread up tests to reduce execution time. In the #5710 I introduced yet another CI — GitHub Actions. And remove AppVeyor, as GitHub Actions supports WIndows. I suggest first merge my pull request, and then I or you will fix merge conflicts. PS. Finally I fixed the CI failure due to jprichardson/node-fs-extra#805 on Windows (was outdated fs-extra dependency due to outdated ts-jsdoc package). |
|
Ahh I was wondering why/how the multi-ci provider was set up! Yes, definitely. I'll just close this for now and revisit it after your PR 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deactivated Tests (to be fixed separately)
Related to #5635 for increasing test coverage