Allow updating mac version running inside Rosetta to native ARM #5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A lot of tests had been failing for me locally probably due to ARM Node environment I am running |
mmaietta
reviewed
May 17, 2021
mmaietta
approved these changes
May 18, 2021
davej
reviewed
May 18, 2021
Co-authored-by: Dave Jeffery <dave@davejeffery.com>
mmaietta
approved these changes
May 19, 2021
mmaietta
reviewed
May 21, 2021
mmaietta
approved these changes
May 29, 2021
|
Which electron-updater version is this released in? I'm on the latest stable (4.3.9) and this doesn't seem to work |
|
It was released as part of 22.11.8 deployment. So ^4.4.0 should work |
|
Thanks for the response @mmaietta. Is 22.11.8 and 4.4.0 stable enough for production, or should I wait for a stable deployment? Asking because it is marked as a pre-release |
|
@praneetrohida see here if you’re using an older version of Electron. #6000 AFAIK this is why it was marked as pre-release. If you’re using a newer version of Electron then it might be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5672