fix(app-builder-lib): macOS packager uses static icon name

[sr258]

The filename of the app icon in macOS is now always 'icon.icns' instead of a derivate of the product name. The reason for this change is that macOS doesn't display icons with non-ASCII characters in their names, which is quite possible in languages other than English.

This fixes one of the issues described here #6282

[changeset-bot]

🦋 Changeset detected

Latest commit: 8fc206c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
app-builder-lib	Patch
dmg-builder	Patch
electron-builder-squirrel-windows	Patch
electron-builder	Patch
electron-forge-maker-appimage	Patch
electron-forge-maker-nsis-web	Patch
electron-forge-maker-nsis	Patch
electron-forge-maker-snap	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✔️ Deploy Preview for jolly-roentgen-9c9aba ready!

🔨 Explore the source changes: 8fc206c

🔍 Inspect the deploy log: https://app.netlify.com/sites/jolly-roentgen-9c9aba/deploys/6156a550d56b9f0007eebb1e

😎 Browse the preview: https://deploy-preview-6308--jolly-roentgen-9c9aba.netlify.app

[mmaietta]

Can you try rebasing this off latest master? Not sure why one of the tests are failing

[sr258]

@mmaietta I rebased this and fixed the test snapshots as far as possible. Unfortunately, I can't really run the tests on my dev machine, as I use an M1 processor, which causes lots of tests to fail even though they shouldn't (see #6310). I hope the CI pipeline runs through this time.