Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: v23.0.0 alpha #6556

Merged
merged 21 commits into from Jan 16, 2022
Merged

chore: v23.0.0 alpha #6556

merged 21 commits into from Jan 16, 2022

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Jan 16, 2022

Fixes:

Features:

Breaking changes:

  • Removing Bintray support since it was sunset. Ref: https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/
  • Fail-fast for windows signature verification failures. Adding -LiteralPath to update file path to disregard injected wildcards
  • Force strip path separators for backslashes on Windows during update process
  • Authentication for local mac squirrel update server
  • Disabled advertised shortcuts, since MSIs with advertised Start Menu shortcuts that have a
    Shortcut Property fails to install when deployed machine-wide via GPO but works fine in all
    other contexts. Admins using advertisement must apply an MST to re-enable it. See MSI fails to install when deployed machine-wide via GPO #6508.
  • Removing optional NSIS icon ID from config and generating it automatically to synchronize IDs with Advertised Shortcuts and future features

mmaietta and others added 20 commits December 29, 2021 12:51
…g `-LiteralPath` to update file for injected wildcards
* feat(mac): ElectronAsarIntegrity in electron@15
See: electron/electron#30667
Fix: #6506
Fix: #6507
)

* fix(msi): MSI fails to install when deployed machine-wide via GPO
Disable advertised shortcuts, since MSIs with advertised Start Menu shortcuts that have a
Shortcut Property fails to install when deployed machine-wide via GPO but works fine in all
other contexts. This might be a bug in Windows or a misdiagnosis; see #6508 for more details.
Closes #6508
BREAKING CHANGE: Admins using advertisement must apply an MST to re-enable it. See #6508.
…#6201)

Signed-off-by: Omer Akram <om26er@gmail.com>
Co-authored-by: Maximilian Federle <max.federle@gmail.com>
fix(win): iconId sometimes containing invalid characters, and iconId config option being ignored.
fix(msi): change the fallback value for generated MSI Ids to a unique string for the product.

BREAKING CHANGE: remove MSI option `iconId`
…licitly segment env.___TOKEN integration tests from other standard unit tests
@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2022

🦋 Changeset detected

Latest commit: c073f90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
app-builder-lib Major
builder-util Major
builder-util-runtime Major
electron-publish Major
electron-updater Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-builder Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 16, 2022

✔️ Deploy Preview for car-park-attendant-cleat-11576 ready!

🔨 Explore the source changes: c073f90

🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/61e376201f2b10000717fd22

😎 Browse the preview: https://deploy-preview-6556--car-park-attendant-cleat-11576.netlify.app

Add basic support for assisted installer, with UI to choose between per-user and per-machine. Supported config settings: runAfterFinish, perMachine, oneClick. Not supported: license (EULA), allowToChangeInstallationDirectory, etc. Also prevent oneClick's runAfterFinish from executing when installed silently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants