Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes for server auth for MacUpdater #6587

Merged
merged 2 commits into from Jan 28, 2022

Conversation

devinbinnie
Copy link
Contributor

This PR fixes a few issues I found when I was testing the MacUpdater:

  • crypto doesn't export a default module, so you have to import the method you want.
  • We were encoding the auth header backwards, now we encode into base64 and decode to ascii
  • There's an issue with Electron/Squirrel.Mac in which when the proxy server is hit to get the file, it doesn't send any of the specified headers. So I had to rework to just check the first hit for authentication (which you need to get the file name anyways), and the second for the first itself will not be authenticated. Since the file name is randomly generated, this should still avoid the security issue in which an attacker could shut down the server. NOTE: We might want to make the file name a little more secure, but that's up for debate.

Let me know if I need to adjust anything :)

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2022

🦋 Changeset detected

Latest commit: 411a5e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for car-park-attendant-cleat-11576 ready!

🔨 Explore the source changes: 411a5e5

🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/61f32a577575650008563e32

😎 Browse the preview: https://deploy-preview-6587--car-park-attendant-cleat-11576.netlify.app

@mmaietta mmaietta merged commit 8746f91 into electron-userland:master Jan 28, 2022
@github-actions github-actions bot mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants