Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(updater): Support Electron 11 and below (Node < 14) #6594

Merged

Conversation

mmaietta
Copy link
Collaborator

Replacing fs/promises with fs-extra to support legacy versions of Electron that use node 12 and below.
Fixes: #6000

Regenerating docs addition from PR #6585 (docs needed to be added to source code, which autogenerates the .md file)

…ctron that use node 12 and below.

Fixes: electron-userland#6000

Regenerating docs addition from PR electron-userland#6585
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2022

🦋 Changeset detected

Latest commit: eba555b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 30, 2022

✔️ Deploy Preview for car-park-attendant-cleat-11576 ready!

🔨 Explore the source changes: eba555b

🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/61f7ff7a63d0590007802899

😎 Browse the preview: https://deploy-preview-6594--car-park-attendant-cleat-11576.netlify.app

@mmaietta mmaietta merged commit edc4b03 into electron-userland:master Jan 31, 2022
@mmaietta mmaietta deleted the fix/updater-support-electron-pre-11 branch January 31, 2022 16:07
@kaatt
Copy link

kaatt commented Feb 1, 2022

fs.promises works in older node/electron versions, fs/promises doesn't.

@mmaietta
Copy link
Collaborator Author

mmaietta commented Feb 1, 2022

@kaatt yes, that's why I switched it back to the original implementation that leveraged fs-extra. Did that not satisfy this ticket?

@kaatt
Copy link

kaatt commented Feb 1, 2022

fs-extra is a good solution

@mmaietta mmaietta linked an issue Feb 5, 2022 that may be closed by this pull request
@github-actions github-actions bot mentioned this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'fs/promises' 2 Breaking change in electron-updater 4.3.10
2 participants