Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app-update.yml to avoid errors #6615

Closed
wants to merge 1 commit into from
Closed

Add app-update.yml to avoid errors #6615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/app-builder-lib/src/targets/snap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,11 @@ export default class SnapTarget extends Target {
if (snap.compression != null) {
args.push("--compression", snap.compression)
}

const publishConfig = getAppUpdatePublishConfiguration(packager, arch, false /* in any case validation will be done on publish */)
if (publishConfig != null) {
await outputFile(path.join(packager.getResourcesDir(stageDir.dir), "app-update.yml"), serializeToYaml(publishConfig))
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this change, being applied to only snap, resovles the issue for deb/rpm builds that also do not support auto-updates.


if (packager.packagerOptions.effectiveOptionComputed != null && (await packager.packagerOptions.effectiveOptionComputed({ snap, desktopFile, args }))) {
return
Expand Down