Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updater "Error: Could not connect to the server." in macOS #6743

Merged
merged 2 commits into from Apr 7, 2022

Conversation

YanDevDe
Copy link
Contributor

@YanDevDe YanDevDe commented Mar 26, 2022

If squirrelDownloadedUpdate is false, then we still need to have the proxy server opened for the "update-downloaded" event. Otherwise you're getting following error:

[2022-03-26 17:18:30.258] [info]  Proxy server for native Squirrel.Mac is closed (fileToProxy=https://utils.pacprotocol.com/yansafe-testnet/build/mac/yanSAFE-testnet-2.2.1-testnet.4-arm64-mac.zip)
[2022-03-26 17:18:30.274] [warn]  Error: Verbindung zum Server konnte nicht hergestellt werden.
[2022-03-26 17:18:30.274] [error] Error: Error: Verbindung zum Server konnte nicht hergestellt werden.

"Error: Verbindung zum Server konnte nicht hergestellt werden." = "Error: Could not connect to the server."

Moving this.server.close() after this.nativeUpdater.quitAndInstall() fixes the issue.

@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2022

🦋 Changeset detected

Latest commit: 1b2e60c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Mar 26, 2022

Deploy Preview for car-park-attendant-cleat-11576 failed.

Name Link
🔨 Latest commit 1b2e60c
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/624b465cf5ac8c0008d03c55

@YanDevDe YanDevDe changed the title Don't close server directly at quitAndInstall fix: Updater "Couldn't connect to proxy server" in macOS Mar 26, 2022
@YanDevDe
Copy link
Contributor Author

Related to this issue #6699

@YanDevDe YanDevDe changed the title fix: Updater "Couldn't connect to proxy server" in macOS fix: Updater "Error: Could not connect to the server." in macOS Mar 26, 2022
@mmaietta mmaietta self-assigned this Apr 4, 2022
@mmaietta mmaietta merged commit 27f18aa into electron-userland:master Apr 7, 2022
@mmaietta
Copy link
Collaborator

mmaietta commented Apr 7, 2022

Thank you for your contribution!

@github-actions github-actions bot mentioned this pull request Apr 7, 2022
@gbacskai
Copy link

I still have the same issue because of ping 127.0.0.1 is:
PING 127.0.0.1 (127.0.0.1): 56 data bytes
ping: sendto: Can't assign requested address

Seems the firewall restrict the 127.0.0.1 access.

Can the server listen on an other ip address what is linked to network adapter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants