Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace typed-emitter with manual implementation of typed event emitter for AppUpdater #6858

Closed

Conversation

Nokel81
Copy link
Contributor

@Nokel81 Nokel81 commented May 11, 2022

Signed-off-by: Sebastian Malton sebastian@malton.name

This PR fixes issues related to the building of docs from #6825

…er for AppUpdater

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@changeset-bot
Copy link

changeset-bot bot commented May 11, 2022

🦋 Changeset detected

Latest commit: 1bb8b96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 11, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 1bb8b96
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/627be6271c1bc80008acf70e
😎 Deploy Preview https://deploy-preview-6858--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Sebastian Malton <sebastian@malton.name>
@mmaietta
Copy link
Collaborator

Nice approach!

I was able to resolve it though via an override that parses any node_module in the jsdoc and just outputs it as a basic class (no hyperlink)

const lastIndex = it.lastIndexOf("node_modules")
it = lastIndex < 0 ? it : `module:${it.substring(lastIndex + 13)}`;
return tagOpen + link2(catharsis.parse(it, {jsdoc: true}), delimiter, root, isSkipNull) + tagClose

It also would allow other node_module packages to be utilized and/or the TypedEventEmitter to be utilized elsewhere in the app

@Nokel81
Copy link
Contributor Author

Nokel81 commented May 11, 2022

That is true. I am fine with either approach.

@mmaietta mmaietta closed this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants