Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add installDir property for NsisUpdater #6907

Merged
merged 2 commits into from Jul 5, 2022
Merged

feat: Add installDir property for NsisUpdater #6907

merged 2 commits into from Jul 5, 2022

Conversation

panther7
Copy link
Contributor

@panther7 panther7 commented May 31, 2022 •
edited

Add installDir property for NsisUpdater. Now is it posible change install folder from AppUpdater.

#6818

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2022 •
edited

🦋 Changeset detected

Latest commit: 8468213

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented May 31, 2022 •
edited

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 8468213
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/62b43b0a7ba39400085066e1
😎 Deploy Preview https://deploy-preview-6907--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@panther7 panther7 changed the title Updater nsis install path Feat: Add installDir variable for NsisUpdater May 31, 2022
@panther7 panther7 changed the title Feat: Add installDir variable for NsisUpdater feat: Add installDir variable for NsisUpdater May 31, 2022
@panther7 panther7 changed the title feat: Add installDir variable for NsisUpdater feat: Add installDir property for NsisUpdater May 31, 2022
@mmaietta
Copy link
Collaborator

mmaietta commented Jun 1, 2022

I'm not sure if this is the correct location for an NSIS-only property. Would it perhaps be better to add to NsisUpdater.ts as a property there?
Users would need to cast an updater to NsisUpdater first though in order to use it. What are your thoughts?

@panther7 panther7 force-pushed the updater-nsis-installPath branch 2 times, most recently from 1ed0972 to f2e837e Compare June 7, 2022 16:01
@mmaietta
Copy link
Collaborator

I'm still not in favor of this PR as mentioned here: #6907 (comment)

We shouldn't add os-specific properties to the base AppUpdater

@panther7
Copy link
Contributor Author

@mmaietta Moved to NsisUpdater.ts

@panther7
Copy link
Contributor Author

Hi Mike,
all changes applied, what now?
Thanks

@mmaietta

@mmaietta mmaietta removed the blocked label Jul 5, 2022
@mmaietta mmaietta merged commit e7f2867 into electron-userland:master Jul 5, 2022
@github-actions github-actions bot mentioned this pull request Jul 6, 2022
Merged
panther7 added a commit to panther7/electron-builder that referenced this pull request Jul 11, 2022
@panther7
Fix installDir definition electron-userland#6907
67b961a
panther7 added a commit to panther7/electron-builder that referenced this pull request Jul 11, 2022
@panther7
fix: installDir definition electron-userland#6907
583325d
@github-actions github-actions bot mentioned this pull request Jul 15, 2022
Merged
@panther7 panther7 deleted the updater-nsis-installPath branch June 16, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaietta mmaietta mmaietta left review comments

Assignees
No one assigned
Labels
electron-updater
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@panther7 @mmaietta