feat: upgrade Keygen integration to v1.1

[ezekg]

Follow up to #6909, which covers the API changes more in-depth. This should have no breaking changes for app's that are upgrading from v1.0 to v1.1 of the API, since it's only related to publishing (the auto-upgrade functionality still works as it did before from a consumer standpoint), so I think it's safe to include in a minor electron-builder update.

I don't think this should be merged until #6920 is out, to give an option to pin to v1.0 for whatever reason (via #6909).

[changeset-bot]

🦋 Changeset detected

Latest commit: d1cf92c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
app-builder-lib	Minor
electron-updater	Minor
dmg-builder	Minor
electron-builder-squirrel-windows	Minor
electron-builder	Minor
electron-forge-maker-appimage	Minor
electron-forge-maker-nsis-web	Minor
electron-forge-maker-nsis	Minor
electron-forge-maker-snap	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name	Link
🔨 Latest commit	d1cf92c
🔍 Latest deploy log	https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/62a771f5cc9c32000906c948
😎 Deploy Preview	https://deploy-preview-6941--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[ezekg]

I'd prefer to start with a DRAFT status for the release, and publish only after all artifacts are uploaded, but I couldn't find a hook to accomplish that (i.e. letting the publisher perform an additional request once all artifacts are uploaded). LMK if one exists and I just happened to miss it.

[mmaietta]

Hmmm, I don't see any in the code for that functionality, but it totally seems like a valid reason to have one added :)
Seems like an onArtifactUploaded could be added here? Simply need to add a task (i.e. Promise) to the taskManager after the scheduleUpload

electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts

Lines 123 to 133 in 03cc9b9

	packager.artifactCreated(event => {
	const publishConfiguration = event.publishConfig
	if (publishConfiguration == null) {
	this.taskManager.addTask(this.artifactCreatedWithoutExplicitPublishConfig(event))
	} else if (this.isPublish) {
	if (debug.enabled) {
	debug(`artifactCreated (isPublish: ${this.isPublish}): ${safeStringifyJson(event, new Set(["packager"]))},\n publishConfig: ${safeStringifyJson(publishConfiguration)}`)
	}
	this.scheduleUpload(publishConfiguration, event, this.getAppInfo(event.packager))
	}
	})

From my quick look, an onAllArtifactsUploaded hook could probably be added here:

electron-builder/packages/app-builder-lib/src/publish/PublishManager.ts

Lines 230 to 241 in 03cc9b9

	async awaitTasks(): Promise<void> {
	await this.taskManager.awaitTasks()
	const updateInfoFileTasks = this.updateFileWriteTask
	if (this.cancellationToken.cancelled || updateInfoFileTasks.length === 0) {
	return
	}
	await writeUpdateInfoFiles(updateInfoFileTasks, this.packager)
	await this.taskManager.awaitTasks()
	}
	}

[mmaietta]

If only adding onAllArtifactsUploaded, which is probably all we need for now, the best place might just be adding it here:

electron-builder/packages/app-builder-lib/src/index.ts

Line 113 in 03cc9b9

promise = publishManager.awaitTasks()

[ezekg]

I was thinking about doing that in a separate follow-up PR, and then updating the Keygen publisher while I'm there. Is that cool? As-is, I think the current publisher works even if it does skip the draft stage.

[mmaietta]

Works for me 😄
I think this is Ready for Review then? Merge button is disabled atm

[ezekg]

Yeah, it's ready for review but I wanted to wait until #6920 is out (which includes #6909) before we consider merging it, so I'm keeping the PR in draft mode. Detailed more of the reasoning there in the PR description.

LMK if you want me to move it out of a draft state. 👍

[mmaietta]

Published 23.2.0 + electron-updater@5.0.6

[ezekg]

Awesome. Marked this as ready for review. 👍