Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Treat cscLink empty same as absent #8185

Merged
merged 2 commits into from Apr 29, 2024

Conversation

mifi
Copy link
Contributor

@mifi mifi commented Apr 25, 2024

I think this is expected with env variables that empty string means disabled.

currently if set to empty string it crashes with:
Error: Env WIN_CSC_LINK is not correct, cannot resolve: D:\a\path\to\project not a file

I think this is expected with env variables that empty string means disabled.

currently if set to empty string it crashes with:
Error: Env WIN_CSC_LINK is not correct, cannot resolve: D:\a\path\to\project not a file
Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 3fb1d54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 3fb1d54
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/662bf1995f9fab0008fa7f7d
😎 Deploy Preview https://deploy-preview-8185--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mifi mifi changed the title Treat cscLink empty same as absent fix: Treat cscLink empty same as absent Apr 26, 2024
@mmaietta mmaietta merged commit 5e41c5e into electron-userland:master Apr 29, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants