Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add afterExtract hook #8194

Merged
merged 2 commits into from May 7, 2024
Merged

Conversation

rafaberaldo
Copy link
Contributor

@rafaberaldo rafaberaldo commented May 2, 2024

Add a hook that triggers after the prebuilt Electron binary has been extracted to the output directory.

What I was looking for is a beforeAsar (or afterCopy) hook, but looks like the file copying function is tightly coupled with asar transformation, this is the next best option.

Partially solves #8188 + #5619 + #4422 + #5709

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 7b7e699

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Major
dmg-builder Major
electron-builder-squirrel-windows Major
electron-builder Major
electron-forge-maker-appimage Major
electron-forge-maker-nsis-web Major
electron-forge-maker-nsis Major
electron-forge-maker-snap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 2, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 7b7e699
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/6634da27880c5900081e3fe3
😎 Deploy Preview https://deploy-preview-8194--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rafaberaldo
Copy link
Contributor Author

Not sure why changeset detected major version bump, I've commited a minor change

@mmaietta
Copy link
Collaborator

mmaietta commented May 6, 2024

@rafaberaldo not too sure either why it's flagged as major, but since we're in an alpha release state, I think it should be fine. Thanks for your contribution!

@rafaberaldo
Copy link
Contributor Author

Have any idea why is it failing on mac?

@mmaietta
Copy link
Collaborator

mmaietta commented May 7, 2024

I deactivated the mac test on master. For some reason, all previous versions of electron-builder for FilesTest on mac are broken now. I think a mac update occurred since the test failures randomly appeared last week with no changes to electron-builder.

@mmaietta mmaietta merged commit 588c5db into electron-userland:master May 7, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants