Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appx): Update identityName for windows 10 #8203

Merged
merged 3 commits into from May 6, 2024

Conversation

ifurther
Copy link
Contributor

@ifurther ifurther commented May 6, 2024

Copy link

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: 78de7d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 6, 2024

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 78de7d2
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/663911f51db8b00008b40036
😎 Deploy Preview https://deploy-preview-8203--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmaietta mmaietta merged commit 66d6d6c into electron-userland:master May 6, 2024
12 of 14 checks passed
mmaietta added a commit that referenced this pull request May 6, 2024
@mmaietta
Copy link
Collaborator

mmaietta commented May 6, 2024

Need to revert this PR, it seems it also broke Appx unit tests. Please take a look when you have a chance. Thank you!

mmaietta added a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppX identityName error
2 participants