Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Node 8 syntax #194

Merged
merged 7 commits into from
May 26, 2019
Merged

feat: use Node 8 syntax #194

merged 7 commits into from
May 26, 2019

Conversation

malept
Copy link
Member

@malept malept commented May 15, 2019

BREAKING CHANGE: drop support for Node < 8.

Requires electron-userland/electron-installer-common#27 to be merged/released.

@malept malept requested a review from fcastilloec May 15, 2019 06:16
@malept
Copy link
Member Author

malept commented May 15, 2019

tmp-promise@2.0.0 got yanked, so tests failed. Need to wait for 2.0.1 (and update -common).

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@fcastilloec fcastilloec merged commit 54e28f7 into master May 26, 2019
@fcastilloec fcastilloec deleted the drop-node-6 branch May 26, 2019 19:08
@fcastilloec
Copy link
Collaborator

fcastilloec commented May 26, 2019

This module is ready for a new release 😄
EDIT: @malept, we actually need to update the dependencies on the example. I'll go ahead an submit a new PR with that before releasing a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants