Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dpkg-deb: error: control directory has bad permissions 756 (must… #347

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

flyyuan
Copy link

@flyyuan flyyuan commented Sep 12, 2023

@flyyuan
Copy link
Author

flyyuan commented Sep 15, 2023

@fcastilloec

@fcastilloec
Copy link
Collaborator

fcastilloec commented Sep 15, 2023

@flyyuan
There's already a PR in progress (#261) that should fix this same issue.
From what I just read over there, it was missing a test, which this PR is also missing. If you add a test, you'll probably have better chances of getting this merge.
Last, your approach is slightly different than the older PR, I have no authorization to merge PRs, so I suggest you contact some of the other maintainers to see which direction is best.

PS: Always run any test locally so you don't see basic errors on the CI tests. (npm run test)

@flyyuan
Copy link
Author

flyyuan commented Sep 15, 2023

@fcastilloec Thank you~
I added a unit test for it and ran test locally, which didn't show any errors.

@flyyuan
Copy link
Author

flyyuan commented Sep 15, 2023

@unindented

@flyyuan
Copy link
Author

flyyuan commented Sep 16, 2023

Thank you for your feedback, @fcastilloec. I've taken note of PR #261, but I believe my approach might offer a different solution. I've added a unit test for this and ran the tests locally without encountering any errors. I hope my PR can provide an effective fix, especially considering the issues faced in specific environments like GitHub codespaces.

@unindented , could you please conduct a code review (CR) on this PR when you have a moment? Your insights would be greatly appreciated.

Thanks again for your guidance and suggestions, @fcastilloec

@flyyuan
Copy link
Author

flyyuan commented Sep 21, 2023

@fcastilloec @unindented

@unindented
Copy link
Collaborator

@fcastilloec @unindented

Same as Felipe, I'm no longer a maintainer. Maybe try reaching out to the current maintainers.

@flyyuan
Copy link
Author

flyyuan commented Sep 22, 2023

@erickzhao @VerteDinde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants