Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setSync function, write user data sync. #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhenshuaiwws
Copy link

When I want to save data before the app exits, but the set method does not complete before the end of the process, resulting in the data not saved successfully, so I need to save the data synchronously.

@jviotti
Copy link
Member

jviotti commented May 16, 2017

Hey there, thanks a lot for the contribution! Some comments:

  • Can we add tests for this new function?
  • Since this is a synchronous function, it shouldn't take a callback, but simply return the value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants