Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it compatible with Node 12 / Electron 5 #154

Merged
merged 6 commits into from
Jul 14, 2019

Conversation

aabuhijleh
Copy link
Contributor

@aabuhijleh aabuhijleh commented Jun 27, 2019

  • Update "cld" dependency which was incompatible with Node 12 / Electron 5 and prevented successful compilation.

  • Fix spellchecking on Windows

@quanglam2807
Copy link

Please merge this PR.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three comments, but I'm sure we can get this merged this week!

@felixrieseberg felixrieseberg merged commit b6498a1 into electron-userland:master Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants