Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix types of wrapped Electron methods to return Promise #999

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix types of wrapped Electron methods to return Promise #999

wants to merge 2 commits into from

Commits on Feb 2, 2022

  1. Remove ‘declare module’ from TypeScript declaration 

    ‘declare module’ is for declaring a third-party module, not for
publishing first-party declarations.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
    @andersk
    andersk committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    6d5fac2 View commit details
    Browse the repository at this point in the history

  2. Fix types of wrapped Electron methods to return Promise 

    Fixes electron-userland#878, fixes electron-userland#998.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
    @andersk
    andersk committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    47d1005 View commit details
    Browse the repository at this point in the history