Merge pull request #1 from magicdawn/feat-build-rollup-external

Feat build rollup external
electron-vite · Apr 11, 2022 · 35d1be7 · 35d1be7
2 parents c669b37 + 5172f0b
commit 35d1be7
Showing 1 changed file with 15 additions and 10 deletions.
diff --git a/renderer/index.js b/renderer/index.js
@@ -27,18 +27,24 @@ module.exports = function () {
 
         if (!config.build.rollupOptions) config.build.rollupOptions = {};
         if (!config.build.rollupOptions.output) config.build.rollupOptions.output = {};
+
+        const prodExternals = [...builtinModules.filter(e => !e.startsWith('_')), 'electron'];
+
+        const modifyOutput = output => {
+          if (!output.format) {
+            // the packaged Electron app should use "cjs"
+            output.format = 'cjs';
+          }
+
+          // make builtin modules & electron external when rollup
+          output.external = [...(output.external || []), ...prodExternals];
+        };
         if (Array.isArray(config.build.rollupOptions.output)) {
           config.build.rollupOptions.output.forEach(output => {
-            if (!output.format) {
-              // the packaged Electron app should use "cjs"
-              output.format = 'cjs';
-            }
+            modifyOutput(output);
           });
         } else {
-          if (!config.build.rollupOptions.output.format) {
-            // the packaged Electron app should use "cjs"
-            config.build.rollupOptions.output.format = 'cjs';
-          }
+          modifyOutput(config.build.rollupOptions.output);
         }
 
         // ----------------------------------------
@@ -70,7 +76,7 @@ module.exports = function () {
 
 /**
  * @typedef {Record<string, import('vite-plugin-optimizer').ResultDescription>} ExportCollected
- * @type {(modules: string[]) => ExportCollected} 
+ * @type {(modules: string[]) => ExportCollected}
  */
 function builtinModulesExport(modules) {
   return modules.map((moduleId) => {
@@ -90,7 +96,6 @@ ${exportMembers}
      * @type {ExportCollected}
      */
     const collect = {
-      // 
       [moduleId]: {
         alias: { find: new RegExp(`^(node:)?${moduleId}$`) },
         code: nodeModuleCode,