fix some bug in v0.8.4 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
process env, so that it is easier to use 2. fix(馃悶): VITE_DEV_SERVER_HOST cannot be used directly when VITE_DEV_SERVER_HOST is a ipv6 address or vite config `server.host` is true 3. fix(馃悶): use vite config `mode` as default build mode to avoid build mode not equal to vite config `mode` when vite config `mode` !== 'development' which would lead to render env not equal to electron main or preload 4. fix(馃悶): build electron output after render to avoid the electron output being deleted when the vite config emptyOutDir is `true` and the vite command is `build` 5. fix(馃悶): use `closeBundle` to replace `writeBundle`, because in extreme cases, an error will be reported. For example, `can't find preload module` will occur as an error when `preload` update frequently
Closed
caoxiemeihao
requested changes
Aug 8, 2022
| title: 'Main window', | ||
| }) | ||
|
|
||
| if (process.env.VITE_DEV_SERVER_URL) { |
There was a problem hiding this comment.
Still need wizard spelling in electron main.ts
process.env['VITE_DEV_SERVER_URL']There was a problem hiding this comment.
But Vite3 supported to use process.env.XXX in build.lib mode.
https://github.com/vitejs/vite/blob/c1fa219f7da09d8fca0140c79e62dbce6d54b0e5/packages/vite/src/node/plugins/define.ts#L13-L31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add
VITE_DEV_SERVER_URLto electronprocess env, so that it is easier to use
fix(馃悶): VITE_DEV_SERVER_HOST cannot be used directly when
VITE_DEV_SERVER_HOST is a ipv6 address or
vite config
server.hostis truefix(馃悶): use vite config
modeas default buildmode to avoid build mode not equal to vite config
modewhenvite config
mode!== 'development' which would lead to render envnot equal to electron main or preload
fix(馃悶): build electron output after render to avoid the electron
output being deleted when the vite config emptyOutDir
is
trueand the vite command isbuildfix(馃悶): use
closeBundleto replacewriteBundle, because inextreme cases, an error will be reported. For example,
can't find preload modulewill occur as an errorwhen
preloadupdate frequently