Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show e-depot-tools command output on Windows #563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codebytere
Copy link
Member

Closes #562.

@codebytere codebytere requested review from ckerr and a team as code owners February 26, 2024 15:43
@MarshallOfSound
Copy link
Member

shell: true was added to fix python3 issues a while back #391 we should make sure we aren't making that worse

cc @dsanders11

Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to repro #562 on my machine - I get the expected output?

shell: true is necessary otherwise you have to explicitly put .bat extensions to run them. Testing on this branch, I actually can't run e d gn --help with these changes:

Running "gn --help"
ERROR Failed to run command:
 Error: spawnSync gn ENOENT

@codebytere, can you provide more environment details that might shine some light on the issue? I'm testing on Windows 10, Node.js 16/18/20 and don't see it.

@codebytere
Copy link
Member Author

@dsanders11 sorry i abandoned this but: I was running git bash in Windows 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output incorrectly piped to console on windows
4 participants