Skip to content

Commit

Permalink
fix: deprecation warnings in Electron code (#20805)
Browse files Browse the repository at this point in the history
  • Loading branch information
trop[bot] authored and zcbenz committed Oct 29, 2019
1 parent e286b78 commit 018fc2c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/browser/api/browser-window.js
Expand Up @@ -33,7 +33,7 @@ BrowserWindow.prototype._init = function () {

// Hide the auto-hide menu when webContents is focused.
this.webContents.on('activate', () => {
if (process.platform !== 'darwin' && this.isMenuBarAutoHide() && this.isMenuBarVisible()) {
if (process.platform !== 'darwin' && this.autoHideMenuBar && this.isMenuBarVisible()) {
this.setMenuBarVisibility(false)
}
})
Expand Down
2 changes: 1 addition & 1 deletion lib/browser/guest-view-manager.js
Expand Up @@ -200,7 +200,7 @@ const attachGuest = function (event, embedderFrameId, elementInstanceId, guestIn
nodeIntegrationInSubFrames: params.nodeintegrationinsubframes != null ? params.nodeintegrationinsubframes : false,
enableRemoteModule: params.enableremotemodule,
plugins: params.plugins,
zoomFactor: embedder.getZoomFactor(),
zoomFactor: embedder.zoomFactor,
disablePopups: !params.allowpopups,
webSecurity: !params.disablewebsecurity,
enableBlinkFeatures: params.blinkfeatures,
Expand Down

0 comments on commit 018fc2c

Please sign in to comment.